]> git.koha-community.org Git - koha.git/commit
Bug 29786: Select only specific items for item level holds
authorNick Clemens <nick@bywatersolutions.com>
Tue, 4 Jan 2022 13:37:53 +0000 (13:37 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 18 Jan 2022 00:55:56 +0000 (14:55 -1000)
commit087176138cd7edfc8083941e370c5e43f9534b50
tree212cc594f7e4300b1087bd6816ea352a939f0867
parent04d94627fbe0d3af0df96c21b82f57d2ec183de1
Bug 29786: Select only specific items for item level holds

This patch adjusts get_items_that_can_fill to make two requests:
first the list of items for item-level holds
second the list of biblionumbers for title-level holds

This stops the report from pulling more items for item-level hold

This patch also removes the aliases used in the code - while readability
is a bit harder, it allows for using 'me' in get_items_that_can_fill
Otherwise, this routine would need a parameter to know what we called the table.

To test:
1 - Find a record with many items available
2 - Place an item level hold for an item on the record, not the one with lowest itemnumber
3 - Run 'Hold to pull' report
4 - Note the barcode does not match
5 - Apply patch
6 - Reload report
7 - It matches!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Holds.pm
circ/pendingreserves.pl