]> git.koha-community.org Git - koha.git/commit
Bug 20563: Allow display of requested partners
authorAndrew Isherwood <andrew.isherwood@ptfs-europe.com>
Fri, 13 Apr 2018 08:22:26 +0000 (09:22 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 15 Mar 2019 19:33:37 +0000 (19:33 +0000)
commit0c7d9e4cc884f60af39859dcd674688d98cf3fae
tree823b17c7590a3c792acc8fb4d7cd9b927489c31e
parenta8435679d41663f9045c4b68d65c06678ac71237
Bug 20563: Allow display of requested partners

This patch adds the display of requested partner email addresses when an
ILL backend provides the ability to send requests to partners. Partner
email addresses are displayed in the illlist and illview displays, they
are also included in the 'illrequests' API response.

* api/v1/swagger/paths/illrequests.json:
  - Add 'requested_partners' as an 'embed' enum
* Koha/Illrequest.pm:
  - Add 'requested_partners' accessor calling optional backend 'get_requested_partners' method.
  - Store requested partners upon email send, calling optional backend 'set_requested_partners' method.
  - Add 'requested_parners' embed to overloaded TO_JSON method.
* koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt:
  - Add 'requested_partners' embed to illrequests API call
  - Add render function for "Additional status" datatables column
  - Add display of requested partner email addresses to illlist table
  - Add display of requested partner email addresses to illview display

To test:
1) Enable Interlibrary loans
2) Add a backend that supports sending requests to partners, e.g.
FreeForm
3) Set up at least one partner
4) Create an ILL request
5) Send request to partner(s)
6) Observe partner(s) email address(es) are displayed in "View ILL
requests" view
7) Observe partner(s) email address(es) are displayed in "Manage ILL
request" view

Signed-off-by: mmg@interleaf.ie
https://bugs.koha-community.org/show_bug.cgi?id=20653

Bug 20563: (follow-up) Fix requested partners

As per:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563#c10

Thanks for the suggestion on merging the "Status" and "Additional status" columns, looks much better!

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Illrequest.pm
Koha/REST/V1/Illrequests.pm
api/v1/swagger/paths/illrequests.json
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt