]> git.koha-community.org Git - koha.git/commit
Bug 29018: Make DELETE /patrons/:patron_id check things
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 20 Dec 2021 15:05:59 +0000 (12:05 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 7 Jan 2022 11:24:24 +0000 (06:24 -0500)
commit0e23a877694cff38e48422e26d4bdb8047c0226a
tree4872d79a9baa1e590d77c9a86cfe0808a5ac1b6d
parentfe04bfc2d424b04818e4036fa84fbb8e87267cff
Bug 29018: Make DELETE /patrons/:patron_id check things

When the route was implemented, the checks were overlooked. This patch
adds checks for:
- Guarantees
- Debts
- Current checkouts

Any of those will block deletion, as it should.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail, the route misses checks
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The three conditions prevent deletion!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/REST/V1/Patrons.pm
api/v1/swagger/paths/patrons.yaml