Bug 29754: (QA follow-up) Minor tests tweaks
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 7 Feb 2022 11:58:43 +0000 (08:58 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 11 Feb 2022 12:00:53 +0000 (07:00 -0500)
commit0f0bfcad7c1cfd2ce9baff8ed3cd6208bfe52b04
treedcbedf1e41de7e7abf9b10cd90a86fb1a6b6736c
parentfe59e356a3b2ea32b333d6c1d332468db61feeec
Bug 29754: (QA follow-up) Minor tests tweaks

This patch does two things:

- Wraps the new SIP tests in a single transaction. We do that to avoid
  sub-test interference, specially when test files get big. The provided
  tests are correct and don't require previous tests data.
- Migrated from the introduced 'diag' calls to 'note', as I just learned
  they are the same, but 'note' is only displayed when in verbose mode.
  Which is great to avoid unnecessary noise in Jenkins.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
t/db_dependent/Koha/Patron.t
t/db_dependent/SIP/Patron.t