]> git.koha-community.org Git - koha.git/commit
Bug 29949: Remove use of title-numeric sorting routine from OPAC datatables JS
authorOwen Leonard <oleonard@myacpl.org>
Wed, 26 Jan 2022 12:18:55 +0000 (12:18 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 1 Feb 2022 07:55:40 +0000 (21:55 -1000)
commit26fd5daf5004539aa3443f2909c109c21d836091
treec8a9da7610d22cfca33651414adb59cf89415e6b
parent4549ebd18fcb641842331611e3a43515adc87b3d
Bug 29949: Remove use of title-numeric sorting routine from OPAC datatables JS

This patch removes the use of a specific "title-numeric" sorting routine
from the DataTables configuration of the "Most popular" table. We can
use a "data-order" attribute instead.

The patch also removes the now unused code from our custom DataTables JS
file in both the OPAC and the staff interface (where it was unused).

To test, apply the patch and make sure the OpacTopissue system
preference is enabled.

- In the OPAC, view the "Most popular" page.
- Change the filter settings, if necessary, to get multiple results.
- In the results table, confirm that sorting by number of checkouts
  still works correctly.

A search of the code for instances of "title-numeric" should return only
one in a comment in the official DataTables library.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/js/datatables.js
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-topissues.tt
koha-tmpl/opac-tmpl/bootstrap/js/datatables.js