Bug 35685: Fix after creation actions
authorPedro Amorim <pedro.amorim@ptfs-europe.com>
Wed, 3 Jan 2024 12:01:36 +0000 (12:01 +0000)
committerKatrin Fischer <katrin.fischer@bsz-bw.de>
Fri, 5 Apr 2024 09:51:13 +0000 (11:51 +0200)
commit34aa31b22d8262c108988071949c5bd4dfc78a88
tree5a461d167837f00f574cc292e26f03406b322476
parentade75ea56158e6cf87894d0aeba1711e73dbfcda
Bug 35685: Fix after creation actions

Test plan:

1) Install FreeForm and enable ILLModule, run:
  bash <(curl -s https://raw.githubusercontent.com/ammopt/koha-ill-dev/master/start-ill-dev.sh)
2) Configure ILLModuleDisclaimerByType, visit:
  /cgi-bin/koha/admin/preferences.pl?tab=&op=search&searchfield=ILLModuleDisclaimerByType
  Click "edit" and paste the example code into the sys pref value
3) Create a new OPAC ILL request, visit:
  /cgi-bin/koha/opac-illrequests.pl?method=create&backend=FreeForm
4) Dont put a type or branch, click 'Create', on the next screen click 'Submit'
5) Notice it explodes
6) Apply patch and repeat. It no longer explodes and now shows an error message.

7) (After FQA): Create a normal request, input type and library, submit the type disclaimer
8) Run:
echo "select * from illrequestattributes;" | koha-mysql kohadev
9) Notice type_disclaimer_date and type_disclaimer_value are correctly saved

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
opac/opac-illrequests.pl