]> git.koha-community.org Git - koha.git/commit
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading
authorJacek Ablewicz <abl@biblos.pk.edu.pl>
Mon, 23 Jun 2014 10:08:26 +0000 (12:08 +0200)
committerChris Cormack <chrisc@catalyst.net.nz>
Thu, 26 Jun 2014 23:14:49 +0000 (11:14 +1200)
commit37ec008df79d36f065b1138912cbfd2b3d37565f
treed3b32ebcbb9efc0ff0d9886b1b3b13bc0950063b
parent7b161b5bbe09d80197906aa049080607852066d9
Bug 12143 - hiding alternate address on patron self registration doesn't hide heading

This patch fixes the following issue: in OPAC self registration form,
even if all alternate address fields are configured as hidden,
the heading for "Alternate address" still shows.

To test:

1/ Confirm the issue: hide all alternate adres field names (i.e., enter
B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone|
B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField
system prefrence).
2/ Observe that "Alternate address" section heading still shows
in patron self registration form ("your personal details" tab),
despite that all section fields are configured as hidden.
3/ Apply patch.
4/ Reload OPAC self registration form; confirm that "Alternate address"
is not displyed any longer, and the issue is now fixed.
5/ Remove some field name (e.g. B_address2) from
PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate
address" heading does show if at least one section field is not
hidden.
6/ Test steps 1-5 should be performed/repeated in both bootstrap
and prog OPAC themes.

Followed test plan with prog and bootstrap themes, works as expected.
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt