]> git.koha-community.org Git - koha.git/commit
Bug 30694: Set decreaseloanholds undef when deleting circulation rule
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Tue, 15 Nov 2022 07:31:13 +0000 (09:31 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 19 Jan 2023 23:46:48 +0000 (23:46 +0000)
commit4bc18581f81aaa7872fd785f215acf2b4a4ce280
treefbe4827a0ec40f9c3534d8e19005ff6e7a49ee97
parent8441834b84f71867e2cc67150c3c5e2b4b2cc583
Bug 30694: Set decreaseloanholds undef when deleting circulation rule

When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds" filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 91fc31c32ba14817d989bcd34854ebc8e41fa936)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
(cherry picked from commit 63fd9be98befc0be358b0074b94253befa929f48)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
admin/smart-rules.pl