]> git.koha-community.org Git - koha.git/commit
Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl
authorFridolin Somers <fridolin.somers@biblibre.com>
Thu, 19 Jan 2023 07:12:48 +0000 (21:12 -1000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 10 Mar 2023 17:00:16 +0000 (17:00 +0000)
commit519b4f2b59832f5ce5975add20dc8461ad7ca9bc
tree3fec85c6ab41944f0eefea54d8dc34a46c70fdfc
parent03abd18eb609b7fe103817e9888372b1d58c42c0
Bug 32678: Add new line in authorized values tests in search_for_data_inconsistencies.pl

In search_for_data_inconsistencies.pl, the test for authorized values is a list in one line :
* The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }):
 {94 => AV} {95 => AV} {96 => AV} {97 => AV} {98 => AV} {99 => AV} {100 => AV} {101 => AV} {102 => AV} {103 => AV}

It would be more clear with new lines, especially for scripts (grep, awk ...) :
* The Framework *VR* is using the authorised value's category *LOC*, but the following items.location do not have a value defined ({itemnumber => value }):
 {94 => AV}
 {95 => AV}
 {96 => AV}
 {97 => AV}
 {98 => AV}
 {99 => AV}
 {100 => AV}
 {101 => AV}
 {102 => AV}
 {103 => AV}

Test plan :
1) In koha-testing-docker
2) Delete in authorized values LOC the value AV
3) Run misc/maintenance/search_for_data_inconsistencies.pl
=> You see the new line in result

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 45323886ae4b73007e2ae2f822ae70a0f46435d0)
Signed-off-by: Jacob O'Mara <jacob.omara@ptfs-europe.com>
(cherry picked from commit 1453472e93bc9a5d747b7f8ed08985a6726227a1)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
misc/maintenance/search_for_data_inconsistencies.pl