Bug 34552: Don't exclude payments with no status
authorNick Clemens <nick@bywatersolutions.com>
Fri, 25 Aug 2023 15:51:12 +0000 (15:51 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 18 Sep 2023 15:06:25 +0000 (12:06 -0300)
commit6ee6bea6bfee301146dc2f631480b227d237e43a
tree9b1a41cd924c162c4663d30e6cf34f20b6daa1dc
parentc997fe863f70fa951c71dca73296ed1f497aeca7
Bug 34552: Don't exclude payments with no status

Bug 29664 removed payments with a void status, however, the query also
removed any payments with no status set

Test Plan:
1 - Set up your cash registers and enable POS and add a debit type that is able to be sold
2 - Take 2 payments via POS
3 - Void one payment
4 - Go to Reports->Statistics wizards->Cash register
4) Verify neither shows for the "All payments to the library" and
   "Payment" transaction type filters
5) Apply this patch
6) Restart all the things!
7) Verify the non-voided fee shows for the "All payments to the library" and
   "Payment" transaction type filters and the voided fee does not

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
reports/cash_register_stats.pl