]> git.koha-community.org Git - koha.git/commit
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 6 Jan 2022 10:13:57 +0000 (07:13 -0300)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Thu, 10 Feb 2022 20:50:05 +0000 (20:50 +0000)
commit774e8475944f70347a9d3f8d8337ff61c686c9f9
tree3061b7a1c3e647c0775decf114c95b4263ca731e
parentef040234d932302f9de24752da9df418d4529b06
Bug 29804: Fix Koha::Hold->is_pickup_location_valid exploding

This trivial patch acknowledges the fact bug 28871 is probably not going
to be pushed, and changes the method so  it, internally, uses
Koha::Item->pickup_locations and Koha::Biblio->pickup_locations in
scalar context.

This is probably the correct solution as the discussion on bug 28883
points towards the future removal of the use of wantarray altogether,
eventually.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Hold.t
=> FAIL: It explodes as we see in production, with:
The method Koha::Libraries->branchcode is not covered by tests!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit db9bfb9450939e4335cb53a8068e11693e4b13d6)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Koha/Hold.pm