]> git.koha-community.org Git - koha.git/commit
Bug 13321: Fix the prices calculation method
authorJonathan Druart <jonathan.druart@biblibre.com>
Mon, 17 Nov 2014 11:06:09 +0000 (12:06 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 28 Oct 2016 13:46:07 +0000 (13:46 +0000)
commit7e89301ab2eca57aa13256f9ed4c8351834476e3
tree87d3971fb73421da6d097e1851b76032ee061cb3
parent42c8019b4dc29211a76f82b6c95855e5601a6345
Bug 13321: Fix the prices calculation method

Well, we have finally arrived here \o/

The method where the prices are calculated uses the equations listed on
the wiki page (http://wiki.koha-community.org/wiki/GST_Rewrite_RFC).

The ecost is calculated from the rrp (using the discount and the tax
rate). That's why we removed the ability to edit this value.

That's why we remove the ability to edit the ecost on ordering in a
previous commit (bug 12840).

The total is now calculated in the scripts. That's why this patch
removes lines in the test file.

In C4::Acquisition::populate_order_with_prices, the calculation on
receiving must depend on the 'invoiceincgst' supplier parameter, and not
listincgst (which is used on ordering).
It also removes the rounding errors, now we store "exact" values in DB
(10^-6).
The values will be displayed using the Price TT plugin it will round the
values for us.

Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Signed-off-by: Francois Charbonnier <francois.charbonnier@inlibro.com>
Signed-off-by: Sonia Bouis <sonia.bouis@univ-lyon3.fr>
Signed-off-by: Sonia Bouis <koha@univ-lyon3.fr>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Acquisition.pm
acqui/basket.pl
acqui/basketgroup.pl
acqui/finishreceive.pl
acqui/invoice.pl
acqui/parcel.pl
koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt
t/Prices.t