Bug 31036: Treat SIP00 that same as CASH
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 24 Jun 2022 08:20:52 +0000 (09:20 +0100)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Fri, 26 Aug 2022 12:08:48 +0000 (14:08 +0200)
commit94cc4b1ea71ddffccbfe4acf52582764a1f141ed
tree4ad5d90ffa897100d56e59a6fd7230a13cd12249
parentf92913f8c9b6d6e3d3b891d0382ad45edda2a5a6
Bug 31036: Treat SIP00 that same as CASH

SIP00 is the code for CASH transactions that have taken place on a SIP
client.  Cash management treats CASH type transactions as a special case
for banking and register requirements. This patch brings SIP00 in line
with the CASH handling code of cash management.

Test plan
1) Enable cash management with 'EnablePointOfSale'
2) Enable cash registers with 'UseCashRegisters'
3) Add a cash register via 'Administration > Cash registers'
4) Make some payments against the ash register in the staff client
5) Attempt to make a payment via a SIP client without having associated
   a cash register to the SIP account config
5a) This should now fail
6) Attach the cash register to the SIP account used above
6a) Payment should now work again on SIP transactions
7) Look at the cash register details page for the cash register
7a) 'Bankale' should now include cash from both SIP and Staff client
sales

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9d8be887d08f523171faa30b35ff86798c4b0115)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit c3c889e7f4b440bcbac8ac0a3eb77e5cfe4c322a)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
Koha/Account.pm
Koha/Account/Line.pm
koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt