]> git.koha-community.org Git - koha.git/commit
Bug 19023 - inventory tool performance
authorFridolin Somers <fridolin.somers@biblibre.com>
Wed, 2 Aug 2017 09:21:58 +0000 (11:21 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 9 Aug 2017 19:51:41 +0000 (16:51 -0300)
commit95f1844e6c46ff51de9f95f99fcdf3369c756fd4
treeaf9eb73bdbad78a5e55af08a00d2e9c3d319c443
parent2fdfbaf0ddbf214c0efb9a3a3c2595a54517f795
Bug 19023 - inventory tool performance

Inventory tool performance seems to be worst since 16.11.
I think it is because of authorized values computing changed by Bug 17249.

For each subfield of each item, we try to get the authorized value description with Koha::AuthorisedValues->search_by_marc_field.
But this method does not use cache like Koha::AuthorisedValues->get_description_by_koha_field.

I propose to use Koha::AuthorisedValues->get_description_by_koha_field and also to look for authorized value description only for item fields used in TT : location, notforloan, itemlost, damaged, withdrawn.

I have experimented inventory time on 100 items from 5s to 1s.

Test plan :
- Without patch
- Perform inventory with barcode file
- Check results and mesure execution time
- Apply patch
- Reperform inventory with same barcode file
- Check results is the same
- Compare execution time
- Run prove t/db_dependent/Items/GetItemsForInventory.t

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
tools/inventory.pl