Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title
authorLari Taskula <lari.taskula@hypernova.fi>
Mon, 20 Sep 2021 22:33:42 +0000 (22:33 +0000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 8 Oct 2021 12:26:05 +0000 (08:26 -0400)
commit971cbd5b8e0c84239763022ddf0bbceaba54beb5
tree9bfbb6e5f767eed91febb09b42d5f4c969296c42
parent328804c6a1bdbd00214fa255259f462e46e96835
Bug 29067: Remove duplicate conditional statement from OPAC messaging settings title

We can never reach the first [% ELSE %]Koha online[% END %] block in OPAC
messaging preferences title, so it's dead code.

This patch removes the useless duplicate if-statement.

To test:
1. Enable EnhancedMessagingPreferencesOPAC system preference
2. Go to /cgi-bin/koha/opac-messaging.pl
3. Observe title Your messaging settings > Koha online catalog
4. Apply patch
5. Refresh page /cgi-bin/koha/opac-messaging.pl
6. Observe same title Your messaging settings > Koha online catalog
7. See patch content
8. Confirm there are no functional changes in the new logic

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt