]> git.koha-community.org Git - koha.git/commit
Bug 29283: Don't attempt to cancel cancelled orders
authorNick Clemens <nick@bywatersolutions.com>
Wed, 20 Oct 2021 13:06:06 +0000 (13:06 +0000)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 5 Nov 2021 12:37:00 +0000 (08:37 -0400)
commit9aa8470382a78558baadcfb13dc545410cc0e70f
tree411d555982759c81891ec109deea98fe02179027
parent8fa126ee40eba088af32228a5e369cd8a526a126
Bug 29283: Don't attempt to cancel cancelled orders

When deleting a basket we cancel all the contained orders - when a
basket contains an order that was previously cancelled this can cause
an error if the biblio was deleted

When picking the orders to cancel, we should limit our search
to those not already cancelled.

To test:
- have a basket with at least one order
- click "Cancel order and delete catalog record", confirm cancellation of order and deletion of bib
- click "Delete basket", confirm deletion
- get error "Cannot insert order: Mandatory parameter biblionumber is missing at /kohadevbox/koha/acqui/basket.pl line 136.
 at /usr/share/perl/5.28/Carp.pm line 289"
- apply patch
- restart
- delete the basket
- success!

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
acqui/basket.pl