]> git.koha-community.org Git - koha.git/commit
Bug 20811: (QA follow-up) Make the isbn check work
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 20 Jul 2018 09:21:11 +0000 (11:21 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Mon, 23 Jul 2018 15:08:56 +0000 (15:08 +0000)
commita49a7f08d6dbaf992d70420dae744c75c2ad8aae
treec6bbd9e4de76312e178484ca9e333895773a305d
parentd15185025a146656a1ad0d7d5a8eb261581c0f1e
Bug 20811: (QA follow-up) Make the isbn check work

The following code was never reached, since $isbn was not filled.
    if (!$biblionumber && $isbn_check && $isbn) {
        $sth_isbn->execute($isbn);
        ($biblionumber,$biblioitemnumber) = $sth_isbn->fetchrow;
    }
Solution: Fix the code with two $isbn declarations. Move the checkisbn
condition a level deeper.

Test plan:
Run misc/migration_tools/bulkmarcimport.pl -file bib726.utf8 --update -isbn
Since you do not match on biblionumber, the ISBN should match.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
misc/migration_tools/bulkmarcimport.pl