]> git.koha-community.org Git - koha.git/commit
Bug 21620: Prevent stockrotation cronjob failures
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 19 Oct 2018 13:37:26 +0000 (14:37 +0100)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 2 Nov 2018 10:33:00 +0000 (10:33 +0000)
commitca3c2b0b639f571981570d4a342c74a1ca026996
treeeccee94f1a58e175499ae5570da20a4cbf23b96f
parentebf0336059635f2ea13c7f626b794e92e4980f46
Bug 21620: Prevent stockrotation cronjob failures

Superflous use of sprintf combined with rebasing issue left the
stockrotation cronjob such that a 'No action taken' email report would
catastrophically fail with the error:

Redundant argument in sprintf at ./stockrotation.pl line 316

This patch both resolves the error and cleans up some additional
unrequired sprintf usage.

Test Plan
1) Create a rotation plan
2) Add some items to the rotation plan
3) Run the cronjob using `stockrotation.pl --report=email --send-email
--execute`
4) Note the lack of errors

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
misc/cronjobs/stockrotation.pl