]> git.koha-community.org Git - koha.git/commit
Bug 31482: Label creator does not call barcodedecode
authorKyle Hall <kyle@bywatersolutions.com>
Mon, 29 Aug 2022 13:26:44 +0000 (09:26 -0400)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Tue, 15 Nov 2022 17:12:13 +0000 (18:12 +0100)
commitcdde1c89ada33ec0ed3bb66dc452768e12d46484
tree3e031d8add09673a9322e5f1a6acf5a4d64406b9
parent4daf1474e165019a792c8271968af8d2de4f2072
Bug 31482: Label creator does not call barcodedecode

The label creator can accept a list of either itemnumbers or item barcodes.
In the case that the list of composed of barcodes, those barcodes should be
passed though barcodedecode before the lookup is performed.

Test Plan:
1) Apply this patch
2) Download and install the Barcode Transformer plugin
   https://github.com/bywatersolutions/koha-plugin-barcode-transformer/releases/
3) Go to the plugin configuration page, set the configuration to the example configuration from the same page
4) On the "New label batch" page of the Label creator,,
   type in some valid barcodes, but prefix them with X and postfix them with Y, e.g. X123456Y
5) Submit the form
6) Note the items are added to the label batch!

JK: Remove unnecessary if $number check, barcodedecode already does this

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 7ddfa8ddd7f558e76c7f6165454453f57dc0a3f9)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 6ccb4d0fff96f4299cf61a5a548a1c576c1d65ef)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
labels/label-edit-batch.pl