]> git.koha-community.org Git - koha.git/commit
Bug 6790: Remove unnecessary variable from getroutinglist return
authorColin Campbell <colin.campbell@ptfs-europe.com>
Fri, 26 Aug 2011 15:17:11 +0000 (16:17 +0100)
committerPaul Poulain <paul.poulain@biblibre.com>
Mon, 23 Jan 2012 16:59:27 +0000 (17:59 +0100)
commitd2c24f3bbff5c3ba96ce5ae8baa2313fabf786d5
treed59aca5b980ae9119fae1347d31c5e1bdeee90d9
parentb32d2d2165d8400713c75a764b7dd2cc0dfdc51d
Bug 6790: Remove unnecessary variable from getroutinglist return

getroutinglist returns a count variable to indicate how many elements
are in the array. This is almost always a serious code smell. (We are
programming in a list manipulating language) The routine was executing
am unnecessary loop just to maintain that var.
Removed the variable from the routine and perldoc
refactored calls of the routine removed the c-style loops for
more idiomatic and maintainable for loops
renamed some opaquely named variables
removed a call to the routine where nothing was done with the data
moved some html out of the calling script and into the template

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
C4/Serials.pm
koha-tmpl/intranet-tmpl/prog/en/modules/serials/routing.tt
serials/routing-preview.pl
serials/routing.pl
serials/subscription-detail.pl