]> git.koha-community.org Git - koha.git/commit
Bug 32975: Error in package.json's definition of css:build vs css:build:prod
authorOwen Leonard <oleonard@myacpl.org>
Wed, 15 Feb 2023 18:19:14 +0000 (18:19 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 10 Mar 2023 12:27:54 +0000 (12:27 +0000)
commitd5c0c5b63ef3ae716e48377dc44304bbbc4542fa
tree87f453f8e27dc51af64693f1d8d8bd8d0ed469c4
parent29ba7bff11b65d9a0536212867bed8788dde9572
Bug 32975: Error in package.json's definition of css:build vs css:build:prod

The "css:build" command runs "gulp css && gulp css --view opac",
processes that build CSS in a development context.

The "css:build:prod" currently runs "gulp build && gulp css --view
opac", which runs the production-oriented command "gulp build" (for the
staff interface), but runs "gulp css --view opac" which is the same
devel-environment command as above.

It should be "gulp build && gulp build --view opac"

To test, apply the patch and run the two commands and check these two
files to confirm the difference:

koha-tmpl/intranet-tmpl/prog/css/staff-global.css
koha-tmpl/opac-tmpl/bootstra/css/opac.css

"yarn css:build" should create unminimized versions of those files.
"yarn css:build:prod" should create minimized versions.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit bc43c6e7febd49000696a4e0d3b42580fcb8910e)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
package.json