]> git.koha-community.org Git - koha.git/commit
Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems...
authorKyle M Hall <kyle@bywatersolutions.com>
Fri, 20 Oct 2017 14:49:38 +0000 (10:49 -0400)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 25 Oct 2017 15:14:32 +0000 (12:14 -0300)
commitd6a1f2ab242474c9e477c2f6d4df5c316a4ef448
tree25ab6d9eaec2b9761e11bf94074cea389dca3dd9
parent42c634745cac4fc33a53bc1312a3e143a2e0ffbc
Bug 19495: Automatic report conversion needs to do global replace on 'biblioitems' and 'marcxml'

Bug 17898 provides a way of converting reports that use biblioitems.marcxml so that they will use biblio_metadata.metadata instead.

This only works with reports that do not refer to other columns in the biblioitems table. This is a known limitation. It means that we should be able to do a substitution of every occurrence of biblioitems with biblio_metadata, and every occurrence of marcxml with metadata.

Unfortunately, we're not doing a global replace, we're only replacing the first occurrence.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/Reports/Guided.t

All tests successful.
Files=1, Tests=9, 10 wallclock secs ( 0.11 usr  0.01 sys +  2.85 cusr  0.25 csys =  3.22 CPU)
Result: PASS

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Reports/Guided.pm
t/db_dependent/Reports/Guided.t