]> git.koha-community.org Git - koha.git/commit
Bug 31033: Explicitly define max child processes for SIP server
authorDavid Cook <dcook@prosentient.com.au>
Fri, 24 Jun 2022 01:42:52 +0000 (01:42 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Wed, 19 Oct 2022 03:07:19 +0000 (05:07 +0200)
commitddea1b55ee39d37ed4ad014e05673f22ef10cf93
tree42d3e5584b5ce41cc42b0c886012a6667c5dc55e
parent7c206f6217705264228817c7d523d0eabbc30714
Bug 31033: Explicitly define max child processes for SIP server

By default, the SIP server appears to only use 1 child process for
responding to SIP connections.

This change makes this explicit in the configuration, which should
make it so that people who need more than 1 simultaneous SIP connection
can know to just increase the value for the "max_servers" parameter
in the SIPconfig.xml file.

Test plan:
1. Add "max_servers='1'" to your SIP configuration file
2. koha-sip --restart kohadev
3. Open 3 terminals
4. Run "telnet localhost 6001" on 2 terminals
5. On the 3rd terminal, run the following:
ss -l -n -t
ps -efww | grep "sip"
6. Note that there are 2 processes called
kohadev-koha-sip: perl /kohadevbox/koha/C4/SIP/SIPServer.pm /etc/koha/sites/kohadev/SIPconfig.xml
One of these processes is the parent of the other
7. The Recv-Q in the "ss" output should show 1
(This means that 1 of your telnet connections is in the server's TCP backlog)
8. Celebrate as the configuration works as expected

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 4a6567274d944814c432ab7b3697c545e1459800)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit e63f552a888e5d0f1746e23e077fb67969f09f72)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
etc/SIPconfig.xml