]> git.koha-community.org Git - koha.git/commit
Bug 10681: remove inappropriate uses of finish() from C4::Circulation
authorKenza Zaki <kenza.zaki@biblibre.com>
Mon, 5 Aug 2013 09:28:03 +0000 (11:28 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 9 Oct 2013 03:40:36 +0000 (03:40 +0000)
commite738f991b0f04003e95e80842c76c547b112b246
tree34dd32f0ea15a1ae27e78112d5b7b58eeab2fd51
parent3b56392a6f99577c69c5636f52be7c51ddbbec73
Bug 10681: remove inappropriate uses of finish() from C4::Circulation

This patch gets rid of finish().

From the man page

finish()
Indicate that no more data will be fetched from this statement handle
before it is either executed again or destroyed.
You almost certainly do not need to call this method.

Adding calls to "finish" after loop that fetches all rows is a common
mistake, don't do it, it can mask genuine problems like uncaught fetch errors.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Circulation.pm