]> git.koha-community.org Git - koha.git/commit
Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl
authorAndrew Nugged <nugged@gmail.com>
Sun, 10 May 2020 10:28:40 +0000 (13:28 +0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 29 Jun 2020 11:44:05 +0000 (13:44 +0200)
commiteb8a0ffcc1bb4d751daa4221bd37faa815904db8
treececb0d7e5aa183f6e8e95479d9e4e0309e9e285c
parentb9ba7151667bc6481bc97335b94e44487c9701bd
Bug 25440: Fix for "CGI::param called in list context" in smart-rules.pl

This warning emitted:

CGI::param called in list context from /admin/smart-rules.pl line 262,
this can lead to vulnerabilities. See the warning in "Fetching the value
or values of a single named parameter" at CGI.pm line 412.

Explained here: https://metacpan.org/pod/CGI#Fetching-the-value-or-values-of-a-single-named-parameter

And because all these params are not multi-params, so simple "scalar .."
forcing for CGI->param is the fix. Changes are transparent and same
values should be assigned as before, just no more warnings.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
admin/smart-rules.pl