Galen Charlton [Sat, 1 May 2010 18:32:44 +0000 (14:32 -0400)]
bug 4396: remove reerences to bi_notforloan
These were causing the OPAC details place hold button to disappear
in circumstances where a bib-level item type was set to a non-loanable
item type even when item-level_itypes was on.
This change does mean that if item-level_itypes is not turned on,
the hold button will now appear for bibs whose bib-level item type
has its not-for-loan flag set; however, if this is a problem, a
better long-term fix would be to use CanBookBeReserved() instead.
Galen Charlton [Sat, 1 May 2010 18:15:42 +0000 (14:15 -0400)]
simplify logic for displaying item status
Flatten the tmpl_if tree for determining the item status
to display and tweaked the order in which statuses are checked to
1. (circ reality) item on loan
2. (circ reality) item in transit
3. (circ reality) item wating at hold shelf
4. (item status that makes circ impossible) item withdrawn
5. (item status that makes circ impossible) item lost
6. (policy that implies no circ but in-house use possible) item not-for-loan per item
7. (policy that implies no circ but in-house use possible) item not-for-loan per item type
8 (item status that *might* affect circ) damaged
8. (fallback) item available
Galen Charlton [Sat, 1 May 2010 18:02:32 +0000 (14:02 -0400)]
bug 4396: clarify return of itemtype-level notforloan flag
* GetItemsInfo now includes a notforloan_per_itemtype key
with the value of the item type's notforloan setting, correctly
set based on the value of the item-level_itypes syspref
* Adjusted OPAC details item status display to use that
notforloan_per_itemtype key
NOTE: one of the assumptions of item-level_itypes is that
you can have either bib-level item types or item-level
item types, but not both in the same database. In particular,
it does not establish a hierarchy where Koha checks the
item-level itemtype first, then the bib-level.
Galen Charlton [Sat, 1 May 2010 17:40:20 +0000 (13:40 -0400)]
bug 4396: create new OPAC template include for item status
As part of preparing to work on bug 4396 (item level item types not
working correctly when biblioitem-level item type is not for loan),
moving the item status template logic to a separate include to make
it easier to work with.
Garry Collum [Sat, 1 May 2010 23:37:06 +0000 (19:37 -0400)]
Bug 3883: Fixes blank line in routing list.
The blank line was being caused by the SELECT statement in the getroutinglist fuction of C4::Serials. The LEFT join in the select statement was creating a single row result of NULL. Changed the LEFT join to an INNER join.
Galen Charlton [Sat, 1 May 2010 14:48:25 +0000 (10:48 -0400)]
bug 4505 followup - template changes
* fix syntax error
* adjust wording - "patron" instead of "borrower"
* handle case where overdue items should require
confirmation of loan by operator
* fix typo in system preference template
Chris Cormack [Sun, 25 Apr 2010 22:30:55 +0000 (10:30 +1200)]
Bug 4405 - Overdues block check out
[Documentation note by RM:
This patch adds a new system preference, OverduesBlockCirc,
that can take one of three values:
- noblock: checkouts permitted even if patrons
have overdue items (default)
- confirmation: circ operator asked to confirm checkout
- block: checkouts to patrons who have overdue
items are forbidden
bug 4256: fix patron replication when using LDAP with auth_by_bind
Patch compiled from diffs created by Dobrica Pavlinušić <dpavlin@rot13.org> to:
* enable patron replication when using LDAP with auth_by_bind
* not scribble over extended patron attributes
* fix failure logging in to OPAC if patron has no extended attributes
Ian Walls [Tue, 6 Apr 2010 16:13:59 +0000 (16:13 +0000)]
Bug 4334: Fixes double quotes error on ODUE line of sample_notices in all languages but French. The error was preventing sample_notices, and any foreign key dependent tables, from loading. This blocked enhancement message preference editing.
Colin Campbell [Fri, 30 Apr 2010 08:46:01 +0000 (09:46 +0100)]
Bug 4333 Fix erroneous message re Active Currency
Script was incorrectly asking user to define an active currency
Now test for active currency in the standard way
Use the currency routines in Budgets where applicable
Move the code paths in the if else to subroutines to clarify flow
Enable warnings
Nicole Engard [Fri, 12 Feb 2010 00:48:15 +0000 (19:48 -0500)]
bug 4170 updated overdue rules
I added a note that this tool should not be used for
advanced notices. The fact that the Delay is required
is actually true based on the tests we did - which
is another bug.
Improve detail page MARC21 XSL file for 505 and 520 tags
Some tags weren't displayed propertly:
505 If there is no indicator 1, content label is not displayed and
then repeated 505 tags are also incorrecly displayed. This patch
add a default label.
502 Wasn't displayed at all. Added in this patch.
Dublin Core schema name space was repeated for each field
as attribute rather than at <oai_dc:dc> level. This reduces
significantly the size of OAI server responses.
Kyle M Hall [Thu, 4 Mar 2010 16:15:47 +0000 (16:15 +0000)]
Search Patrons - Make patron search more forgiving.
Patron search has only been searching fields for names
that either match or begin with the given search terms.
This is too strict a search.
For example, take the name "Billie Jo Robinson", "Billie Jo"
being the firstname, and "Robinson" being the last name. If one
were to search for "Billie Jo", this patron would not appear in
the search results.
To remedy this, the search
type has been changed from 'begins_with' to 'contain'.
Kyle M Hall [Thu, 4 Mar 2010 16:17:05 +0000 (16:17 +0000)]
Circulation - Disable Barcode Field If Item Needs Confirmation
When issuing items, if a confirmation screen comes up,
another item can still be scanned into the barcode field.
If a librarian does not notice the confirmation dialog,
he or she may continue scanning items without confirming
the issue and thus give a patron an item without it actually
being issued to the patron.
This patch disables the barcode field until the confirmation
question is answered.
Owen Leonard [Thu, 29 Apr 2010 15:06:54 +0000 (11:06 -0400)]
Fix for Bug 4271, Offer choice of destination for save biblio operation
A follow-up to the fix for Bug 4121, the user should be able to control whether
the action of saving a bibliographic record takes them to the add item screen
or the detail screen, independently of whether they are adding or modifying the
record.
The addition of a "split button" would leave the default action in place if the
user clicked the "main" part of the button. Clicking on the menu would give the
user specific choices.
one test was failing for want of correct parameters
An other one was not correctly described
test on search with a simple string fails because was done with branchcode and start_with includes NULL branches
Removing branchcode from filtercolumns
Colin Campbell [Wed, 24 Feb 2010 16:59:46 +0000 (16:59 +0000)]
Bug 4248 Rework Cities dropdown for members entry
Garry Collum's patch correctly identified the core flaw in operation
looking closer revealed some other flaws (2 "blank" options, some vars
and documentation belonging to a superceded version, etc.
Changed GetCities to return a structure rather than the messy two returns
Let the template do the concatenation and removed the CGI::Popup
Jane Wagner [Thu, 25 Feb 2010 17:59:08 +0000 (12:59 -0500)]
Bug 4210 Acq suggestions don't have LibraryName value passed
Updated to current head. The various acquisitions suggestion templates have a LibraryName field, but no value is passed for that field. Added a parameter for that data.
Jane Wagner [Wed, 11 Nov 2009 13:40:16 +0000 (08:40 -0500)]
Bug 3782 Update installer info for z39.50 targets
New York Public Library and New York University Library have changed their z39.50 connection information; this patch updates the installer files to the current setups.
Jane Wagner [Mon, 2 Nov 2009 20:05:01 +0000 (15:05 -0500)]
Bug 3750 Modify XSLT to display subfield n of 111/711 and remove period after 110/710
If a 111/711 uses a subfield n (Number of part/section/meeting), XSLT wasn't displaying it which made for an incomplete display.
e.g., International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
instead of 10th International Conference on Concurrency Theory 1999 : Eindhoven, Netherlands)
I've added it to show before subfield a if present. I've also removed the period that XSLT puts in the results and display after the last occurrence of a 110/710. It's fairly standard practice for these entries to have a period in the MARC record, so the XSLT display was showing a double period.
Paul Poulain [Fri, 26 Mar 2010 10:25:38 +0000 (11:25 +0100)]
removing AutoCommit=0, the last item is not commited
For an unknown reason, the last item batch updated is NOT updated.
After investigating a LOT (more than 3 hours), it appears the problem comes from the AutoCommit=0
I tried to solve it, but failed. So I remove the AutoCommit=0 option.
this result in a loss of perfs, but it's not a big problem I think. OTH, now everything is updated !
MT 2269, Follow-up : Granular permissions for items batch modification and deletion
Change of permissions names
Change of branch title in guided reports
Add a "Select All / Clean All" on items selection
Add a link to item when a given item cannot be deleted
Alex Arnaud [Wed, 31 Mar 2010 09:40:48 +0000 (11:40 +0200)]
(BUG #4357) Closing a basket and creating baskets group
when closing a basket without creating a basketgroup, the group is still created => corrected
+ replace "create a basketgroup?" by "create a purchase order now?" in confirmation step.
Alex Arnaud [Wed, 31 Mar 2010 07:14:57 +0000 (09:14 +0200)]
(BUG #4355) Basket.pl: withdrawal of the "can not close the basket" button
Basket.pl: withdrawal of the "can not close the basket"button. only Uncerain
prices button is displayed. And removing the "??" in the price columns,
replaced by "uncertain" in rrp column
Alex Arnaud [Tue, 23 Mar 2010 10:38:34 +0000 (11:38 +0100)]
(BUG #4332) Changed the display of ordered search results
Changing the display of the basket column: changing "basketNumber" to "my
basket (basketNumber)".
Adding the Basket group column with fallowing display: "my group (group
Number)"
projects / koha.git / log