]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm
Mason James [Tue, 26 Jun 2012 14:48:25 +0000 (02:48 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Message.pm

"return" statement with explicit "undef" at line 109, column 9.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 145, column 9.  See page 199 of PBP.  (Severity: 5)
"return" statement with explicit "undef" at line 319, column 9.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm
Mason James [Tue, 26 Jun 2012 14:44:47 +0000 (02:44 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/Output.pm

"return" statement with explicit "undef" at line 128, column 74.  See page 199 of PBP.  (Severity: 5)
Subroutine prototypes used at line 270, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 308, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm
Mason James [Tue, 26 Jun 2012 14:37:09 +0000 (02:37 +1200)]
Bug 6679 - [SIGNED-OFF] fix 3 perlcritic violations in C4/SQLHelper.pm

Subroutine prototypes used at line 251, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 287, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 317, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm
Mason James [Tue, 26 Jun 2012 14:31:06 +0000 (02:31 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/Branch.pm

Subroutine prototypes used at line 157, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 375, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 385, column 1.  See page 194 of PBP.  (Severity: 5)
Subroutine prototypes used at line 418, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm
Mason James [Tue, 26 Jun 2012 14:10:11 +0000 (02:10 +1200)]
Bug 6679 - [SIGNED-OFF] fix 4 perlcritic violations in C4/ShelfBrowser.pm

- Variable declared in conditional statement at line 183, column 5.  Declare  variables outside of the condition.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm
Mason James [Tue, 26 Jun 2012 14:02:26 +0000 (02:02 +1200)]
Bug 6679 - [SIGNED-OFF] fix 5 perlcritic violations in C4/Serials.pm

- Subroutine prototypes used at line 161, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm
Mason James [Tue, 26 Jun 2012 13:53:05 +0000 (01:53 +1200)]
Bug 6679 - [SIGNED-OFF] fix 6 perlcritic violations in C4/Barcodes/hbyymmincr.pm

- Subroutine prototypes used at line 45, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm
Mason James [Tue, 26 Jun 2012 13:30:33 +0000 (01:30 +1200)]
Bug 6679 - [SIGNED-OFF] fix 7 perlcritic violations in C4/Biblio.pm

- Expression form of "eval" at line 492, column 12.  See page 161 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 891, column 5.  See page 199 of PBP.  (Severity: 5)

- Subroutine prototypes used at line 1148, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm
Mason James [Tue, 26 Jun 2012 13:22:21 +0000 (01:22 +1200)]
Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Barcodes.pm

- "return" statement with explicit "undef" at line 57, column 2.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm
Mason James [Tue, 26 Jun 2012 13:20:37 +0000 (01:20 +1200)]
Bug 6679 - [SIGNED-OFF] fix 8 perlcritic violations in C4/Circulation.pm

- "return" statement with explicit "undef" at line 994, column 39.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm
Mason James [Tue, 26 Jun 2012 13:12:24 +0000 (01:12 +1200)]
Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/Koha.pm

- Subroutine prototypes used at line 115, column 1.  See page 194 of PBP.  (Severity: 5)

- "return" statement with explicit "undef" at line 1112, column 4.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm
Mason James [Tue, 26 Jun 2012 13:08:34 +0000 (01:08 +1200)]
Bug 6679 - [SIGNED-OFF] fix 9 perlcritic violations in C4/TmplTokenType.pm

- Subroutine prototypes used at line 86, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm
Mason James [Tue, 26 Jun 2012 04:39:27 +0000 (16:39 +1200)]
Bug 6679 - [SIGNED-OFF] fix 15 perlcritic violations in C4/ImportExportFramework.pm

Bareword file handle opened at line 558, column 17.  See pages 202,204 of PBP.  (Severity: 5)

Two-argument "open" used at line 558, column 17.  See page 207 of PBP.  (Severity: 5)

http://bugs.koha-community.org/show_bug.cgi?id=6679
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violation...
Mason James [Tue, 26 Jun 2012 03:55:46 +0000 (15:55 +1200)]
Bug 6679 - [SIGNED-OFF]fixing 23 '"return" statement with explicit "undef"' violations in C4/Tags.pm

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm
Mason James [Tue, 26 Jun 2012 12:34:43 +0000 (00:34 +1200)]
Bug 6679 -[SIGNED-OFF] fix 12 perlcritic violations in C4/Context.pm

"return" statement with explicit "undef" at line 486, column 5.  See page 199 of PBP.  (Severity: 5)

Subroutine prototypes used at line 548, column 1.  See page 194 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm
Mason James [Tue, 26 Jun 2012 12:38:42 +0000 (00:38 +1200)]
Bug 6679 - [SIGNED-OFF] fix 12 perlcritic violations in C4/Auth_with_ldap.pm

Subroutine prototypes used at line 73, column 1.  See page 194 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 74, column 24.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm
Mason James [Tue, 26 Jun 2012 12:43:07 +0000 (00:43 +1200)]
Bug 6679 - fix 12 perlcritic violations in C4/External/BakerTaylor.pm

Subroutine prototypes used at line 82, column 1.  See page 194 of PBP.  (Severity: 5)

"return" statement with explicit "undef" at line 83, column 22.  See page 199 of PBP.  (Severity: 5)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5339'
Paul Poulain [Thu, 20 Sep 2012 08:19:44 +0000 (10:19 +0200)]
Merge remote-tracking branch 'origin/new/bug_5339'

12 years agoBug 5339 follow-up
Paul Poulain [Thu, 20 Sep 2012 08:19:19 +0000 (10:19 +0200)]
Bug 5339 follow-up

 * fix english error
 * if the invoice is closed, don't display a "finish receiving" link, but a "view invoice" one

12 years agoBug 5339: Unit tests for invoices related subroutines
Julian Maurice [Wed, 19 Sep 2012 13:02:49 +0000 (15:02 +0200)]
Bug 5339: Unit tests for invoices related subroutines

These tests use DBD::Mock to check if SQL queries are correctly built.
Actually, we only check bound parameters.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5339: ergonomic changes
Julian Maurice [Wed, 19 Sep 2012 12:08:28 +0000 (14:08 +0200)]
Bug 5339: ergonomic changes

- "Finish receive" on parcel.pl now redirect to acqui/invoice.pl,
  allowing the librarian to modify invoice informations (freight,
  billing date, ...) and close invoice.
- The librarian can now close (or reopen) the invoice and modify invoice
  informations in 1 operation (instead of 2)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5339: Fix t/db_dependant/Acquisition.t
Julian Maurice [Thu, 20 Sep 2012 07:11:58 +0000 (09:11 +0200)]
Bug 5339: Fix t/db_dependant/Acquisition.t

12 years agoMerge remote-tracking branch 'origin/new/bug_8185'
Paul Poulain [Wed, 19 Sep 2012 16:47:58 +0000 (18:47 +0200)]
Merge remote-tracking branch 'origin/new/bug_8185'

12 years agoBug 6679 Avoid critic failure caused by ambiguous code
Colin Campbell [Wed, 19 Sep 2012 16:23:27 +0000 (17:23 +0100)]
Bug 6679 Avoid critic failure caused by ambiguous code

If countitems not set to 1 it was not being declared
but is referred to outside this scope, generating
runtime warnings and test failure

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 2060 follow-up DBRev & updatedatabase
Paul Poulain [Wed, 19 Sep 2012 15:25:19 +0000 (17:25 +0200)]
Bug 2060 follow-up DBRev & updatedatabase

12 years agoBug 2060 follow-up: add support for UNIMARCAUTH
Jared Camins-Esakov [Fri, 14 Sep 2012 12:46:04 +0000 (08:46 -0400)]
Bug 2060 follow-up: add support for UNIMARCAUTH

The staged MARC management script was not correctly informing
the decoder ring that we had UNIMARC authorities, and the decoder
ring was dutifully trying to turn the authority records into a
bibliographic box of cereal.

12 years agoBug 2060: Update command line MARC import scripts
Jared Camins-Esakov [Mon, 25 Jun 2012 15:38:19 +0000 (11:38 -0400)]
Bug 2060: Update command line MARC import scripts

Expose authority import functionality to the command line import
scripts, and rename them from commit_biblios_file.pl and
stage_biblios_file.pl to commit_file.pl and stage_file.pl.

To test (note that these instructions assume you have a MARC21
installation and are using the provided sample file):
1. Find a file of authorities (a sample file with MARC21 authorities
   is attached to bug 7475) and download it to your server
2. Stage the file using the following command (replace <filename> with
   the name of the file you saved in step 1):
   > misc/stage_file.pl --file <filename> --authorities
3. Note the batch number the script assigns to your batch
4. Commit the records using the following command (replace <batchnumber>
   with the batch number you made note of in step 3):
   > misc/commit_file.pl --batch-number <batchnumber>
5. Index the authorities Zebraqueue (or wait)
6. Confirm that the new authorities appear.
7. Create a matching rule with the following settings:
   Code: AUTHTEST
   Description: Personal name main entry
   Match threshold: 999
   Record type: Authority record
   Search index: Heading-main
   Score: 1000
   Tag: 100
   Subfields: a
   Offset: 0
   Length: 0
   (note the ID of this matching rule)
8. Stage the authority file again, this time using the following
   command:
   > misc/stage_file.pl --file <filename> --authorities \
     --match <matchingrule>
7. Revert the import with the following command:
   > misc/commit_file.pl --batch-number <batchnumber> --revert
8. Index the authorities Zebraqueue (or wait)
9. Confirm that the records have been removed
10. Import an authority record with the Stage MARC/Manage staged MARC
    tools in exactly the way you would for a bibliographic record,
    but choose "Authority" instead of "Bibliographic" for the record
    type.

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Testing plan delivers as it should.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master 11 September 2012

12 years agoBug 7475: Teach matching rules to handle authorities
Jared Camins-Esakov [Mon, 25 Jun 2012 15:34:59 +0000 (11:34 -0400)]
Bug 7475: Teach matching rules to handle authorities

* Add the code necessary to handle authorities with matching rules and
  import batches.
* Update all the scripts that use the matcher and import batch code
  to use the new API.
* Add authority records to the matching rules interface in the staff
  client.

http://bugs.koha-community.org/show_bug.cgi?id=2060
Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on latest master 11 September 2012

12 years agoBug 7475: Update configuration
Jared Camins-Esakov [Mon, 25 Jun 2012 16:36:45 +0000 (12:36 -0400)]
Bug 7475: Update configuration

In order to make matching rules more useful for MARC21 authorities,
this patch adds special indexes on previous see-from headings and
LCCN. This patch does not change UNIMARC authority configuration in
any way. Also modifies the Koha schema in preparation for adding
authority import and matching to the Staging tools.

To install:
1. Run installer/data/mysql/atomicupdate/importauthorities.pl
2. Update the following four files in your koha-dev:
    etc/zebradb/authorities/etc/bib1.att
    etc/zebradb/marc_defs/marc21/authorities/authority-koha-indexdefs.xml
    etc/zebradb/marc_defs/marc21/authorities/authority-zebra-indexdefs.xsl
    etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl
3. Reindex your authorities:
    misc/migration_tools/rebuild_zebra.pl -a -r -v

NOTE TO RM: this patch adds an atomicupdate file that needs to be
incorporated into updatedatabase.pl if bug 7167 is not pushed.

http://bugs.koha-community.org/show_bug.cgi?id=2060

Signed-off-by: Elliott Davis <elliott@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 1 August 2012
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Rebased on master 11 September 2012

12 years agoA follow-up will be added though, because we understood why I had some javascript...
Paul Poulain [Wed, 19 Sep 2012 15:02:14 +0000 (17:02 +0200)]
A follow-up will be added though, because we understood why I had some javascript error and jonathan didn't. It's because I've plack + debug
Bug 8117 follow-up: explicitely list tables to dataTable

debug panel in plack adds a lot of <table> (without any id)
thus, when you call
$("table").dataTable(...)
there's a javacscript error because datatable can't handle the plack <table> !

The solution has been to explicitely name the tables to dataTable (which is a good thing anyway)
        $("#activeperiodst,#inactiveperiodst").dataTable($.extend(true, {}, dataTablesDefaults, {

12 years agoBug 8117 follow-up remove perl warning
Paul Poulain [Wed, 19 Sep 2012 14:29:46 +0000 (16:29 +0200)]
Bug 8117 follow-up remove perl warning

first & last were already defined, removing my

12 years agoBug 8117: Followup: remove h3 title (duplicate infos)
Jonathan Druart [Fri, 3 Aug 2012 12:18:27 +0000 (14:18 +0200)]
Bug 8117: Followup: remove h3 title (duplicate infos)

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8117: Divide budget periods into two tabs
Jonathan Druart [Fri, 20 Jul 2012 14:21:17 +0000 (16:21 +0200)]
Bug 8117: Divide budget periods into two tabs

Budget periods are now divided into two tabs : active and inactive
budget periods.

The original author of this patch is Julian Maurice

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Michael Davis <m.r.davis@cranfield.ac.uk>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
12 years agoMerge remote-tracking branch 'origin/new/bug_6448'
Paul Poulain [Wed, 19 Sep 2012 14:12:23 +0000 (16:12 +0200)]
Merge remote-tracking branch 'origin/new/bug_6448'

12 years agoBug 6448 - carp on invalid barcode
Dobrica Pavlinusic [Fri, 3 Aug 2012 22:03:11 +0000 (00:03 +0200)]
Bug 6448 - carp on invalid barcode

This is consistent with implementation of other barcode types
which all carp instead of die on invalid barcodes.

12 years agoBug 8185: Change some more strings from Italian to English
Mirko Tietgen [Sat, 11 Aug 2012 19:47:05 +0000 (21:47 +0200)]
Bug 8185: Change some more strings from Italian to English

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Two additional corrections

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8185: plugin for linking records in MARC21
Zeno Tajoli [Fri, 3 Aug 2012 13:03:59 +0000 (15:03 +0200)]
Bug 8185: plugin for linking records in MARC21

This plugin works like the unimarc plugin unimarc_field_4XX. It
 insert: $9 -> biblionumber $w -> 001 $t -> 245$a (title )
 $x -> 022$a (ISSN) $z -> 020$a (ISBN) The search is done on
 'any' index. Data are inserted only in the working record.
 To insert data in the connected record, you need to open
 the other record.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8624: Move famfamfam out of theme directory
Jared Camins-Esakov [Mon, 13 Aug 2012 00:50:28 +0000 (20:50 -0400)]
Bug 8624: Move famfamfam out of theme directory

The patch moves the famfamfam image set out of the
koha-tmpl/opac-tmpl/prog/famfamfam into koha-tmpl/opac-tmpl/famfamfam

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6689 [Follow-up] Improve styling of table pager
Owen Leonard [Fri, 14 Sep 2012 18:48:37 +0000 (14:48 -0400)]
Bug 6689 [Follow-up] Improve styling of table pager

Small correction to add non-vendor-prefixed border
radius declaration to make style consistent on
newer browsers.

To test, view a page with a sorted table and pager controls,
like members/readingrec.pl. The pager controls "box" should
show rounded corners in Firefox 15+

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7401 - Shelving Location facet
Kyle M Hall [Thu, 16 Feb 2012 17:09:44 +0000 (12:09 -0500)]
Bug 7401 - Shelving Location facet

This patch enables the shelving location facet as an
alternative to the branches fact in two situations:
A) SingleBranchMode is enabled
B) There is only one branch in the branches table

Test Plan:
1) Catalog multiple items with different shelving locations.
2) Test enable by enabling SingleBranchMode
3) Test enable by deleting all but one branch

Based on initial patch by Ian Walls.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested cases 2) and 3) successfully in OPAC and staff client

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7993'
Paul Poulain [Wed, 19 Sep 2012 10:13:02 +0000 (12:13 +0200)]
Merge remote-tracking branch 'origin/new/bug_7993'

12 years agoBug 7993 follow-up to fix POD DOC
Paul Poulain [Wed, 19 Sep 2012 10:12:43 +0000 (12:12 +0200)]
Bug 7993 follow-up to fix POD DOC

12 years agoBug 7751 follow-up adding updatedatabase for sysprefs decreateLoanHighHolds*
Paul Poulain [Wed, 19 Sep 2012 10:01:11 +0000 (12:01 +0200)]
Bug 7751 follow-up adding updatedatabase for sysprefs decreateLoanHighHolds*

See http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7751#c31 to c34

12 years agoMerge remote-tracking branch 'origin/new/bug_8597'
Paul Poulain [Wed, 19 Sep 2012 09:43:04 +0000 (11:43 +0200)]
Merge remote-tracking branch 'origin/new/bug_8597'

12 years agoBug 8597 follow-up translation issues
Paul Poulain [Wed, 19 Sep 2012 09:42:41 +0000 (11:42 +0200)]
Bug 8597 follow-up translation issues

Replacing 2 french terms by the english one

12 years agoMerge remote-tracking branch 'origin/new/bug_8597'
Paul Poulain [Wed, 19 Sep 2012 09:36:51 +0000 (11:36 +0200)]
Merge remote-tracking branch 'origin/new/bug_8597'

12 years agoBug 8597 follow-up: add missing lib files
Jared Camins-Esakov [Mon, 27 Aug 2012 22:20:08 +0000 (18:20 -0400)]
Bug 8597 follow-up: add missing lib files

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5339 follow-up DBRev
Paul Poulain [Wed, 19 Sep 2012 09:13:36 +0000 (11:13 +0200)]
Bug 5339 follow-up DBRev

12 years agoBug 5339: perltidy on added files
Julian Maurice [Mon, 13 Aug 2012 07:53:37 +0000 (09:53 +0200)]
Bug 5339: perltidy on added files

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5339: Invoices management improvement
Julian Maurice [Fri, 6 Jan 2012 15:51:57 +0000 (16:51 +0100)]
Bug 5339: Invoices management improvement

- New pages:
  - invoices.pl: allow to search in invoices on several criteria
  - invoice.pl: permit to view and modify invoice details
    - shipment date
    - billing date
    - shipment cost and budget used for shipment cost

Invoice informations are now stored in their own sql table and aqorders
have a link to it

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoBug 5357: Follow-up - layout and EAN search
Katrin Fischer [Sat, 25 Aug 2012 21:18:08 +0000 (23:18 +0200)]
Bug 5357: Follow-up - layout and EAN search

1) EAN search should be hidden if marcflavour is not UNIMARC
2) Fixes layout to match the advanced search in acquisitions
- labels in front of the fields instead of separate lines
- adds a legend to the form and moves the toggle for the search form to it

To test:
- EAN search field should only show up when marcflavour system preference
  is set to UNIMARC
- Check layout is consistent and you like it
- Check toggle for advanced search still behaves the same

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5357: Adds a new page for searching subscriptions
Jonathan Druart [Fri, 9 Mar 2012 09:05:38 +0000 (10:05 +0100)]
Bug 5357: Adds a new page for searching subscriptions

Test plan:
- go on the serial module
- click on the 'Advanced search' link (right of subscriptions search in
the header)
- Search subscriptions (by ISSN, title, EAN, Publisher, Supplier and/or
  Branch)
- Check results are correct

Signed-off-by: Corinne HAYET <corinne.hayet@bulac.fr>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7751: Decrease Loans for Items in Demand for Holds
Colin Campbell [Fri, 17 Aug 2012 16:25:47 +0000 (17:25 +0100)]
Bug 7751: Decrease Loans for Items in Demand for Holds

Rebase and merge based on Mark Gavillet's patch to reduce
the loan period given to items on renewal when they are
in high demand for holds

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoBug 7993 follow-up DBRev number
Paul Poulain [Tue, 18 Sep 2012 16:08:12 +0000 (18:08 +0200)]
Bug 7993 follow-up DBRev number

12 years agoBug 7993: Save reports with Group/Subgroup hierarchy
Srdjan [Mon, 10 Sep 2012 01:14:01 +0000 (13:14 +1200)]
Bug 7993: Save reports with Group/Subgroup hierarchy

This should make saved reports more manageable.
Group/Subgroup hierarchy is stored in authorised_values,
categories REPORT_GROUP and REPORT_SUBGROUP, connected by
REPORT_SUBGROUP.lib_opac -> REPORT_GROUP.authorised_value

Database changes:
* authorised_values: expanded category to 16 chars
* created default set of REPORT_GROUP authorised values to match
  hardcoded report areas
* reports_dictionary: replaced area int with report_area text, converted
  values
* saved_sql: added report_area, report_group and report_subgroup;
  report_area is not currently used, saved for the record

C4/Reports/Guided.pm:
* Replaced Area numeric values with the mnemonic codes
* get_report_areas(): returns hardcoded areas list
* created get_report_areas(): returns full hierarchy (groups with belonging
  subgroups)
* save_report(): changed iterface, accepts fields hashref as input
* update_sql(): changed iterface, accepts id and fields hashref as input
* get_saved_reports():]
- join to authorised_values to pick group and subgroup name
- accept group and subgroup filter params
* get_saved_report():
- changed iterface, return record hashref
- join to authorised_values to pick group and subgroup name
* build_authorised_value_list(): new sub, moved code from
  reports/guided_reports.pl
* Updated interfaces in:
cronjobs/runreport.pl, svc/report, opac/svc/report: get_saved_report()
reports/dictionary.pl: get_report_areas()
reports/guided_reports.pl

reports/guided_reports_start.tt:
* Reports list:
- added group/subgroup filter
- display area/group/subgroup for the reports
* Create report wizard:
- carry area to the end
- select group and subgroup when saving the report; group defaults to area,
  useful when report groups match areas
* Update report and Create from SQL: added group/subgroup
* Amended reports/guided_reports.pl accordingly

Conflicts:

    C4/Reports/Guided.pm
    admin/authorised_values.pl
    installer/data/mysql/kohastructure.sql
    installer/data/mysql/updatedatabase.pl
    koha-tmpl/intranet-tmpl/prog/en/modules/reports/dictionary.tmpl
    koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tmpl
    misc/cronjobs/runreport.pl
    reports/dictionary.pl
    reports/guided_reports.pl

Signed-off-by: Delaye Stephane <stephane.delaye@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8210: add links to authorities in normal mode headings
Julian Maurice [Mon, 13 Aug 2012 19:34:51 +0000 (15:34 -0400)]
Bug 8210: add links to authorities in normal mode headings

Cherry-picked from BibLibre's work on bug 5888:
opac-detail subject/author links improvements

Added a link to opac-authoritiesdetail.pl when possible.

Only affects 'Normal view'. Does not affect XSLT display.

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8210: add links to authorities to headings in OPAC
Jared Camins-Esakov [Sat, 4 Aug 2012 17:38:59 +0000 (13:38 -0400)]
Bug 8210: add links to authorities to headings in OPAC

At the moment, there is no way to get to an authority record from a bib
record that uses it other than doing a new search on the authority file.
This patch adds a link (a cute little magnifying glass) to linked
authority records on the OPAC detail view for MARC21 and NORMARC
with XSLT enabled. A follow-up patch will add the link to regular mode.
Because UNIMARC handles authorities differently, the link is not added
to the XSLT.

Test plan:
1) Set OPACXSLTDetailsDisplay to 'default'
2) View a record that has some headings that are linked to authority
   records in the OPAC (easiest way to find a record like that is to
   edit a record and add some headings using the thesaurus plugin)
3) Observe the cute little magnifying glass links to the authority.

Revised version of the patch adds a space between the heading and the
magnifying glass.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works nicely.

If a library does not like to see the
magnifying glass/link to the authority, it's easy to disable it
by adding the line .authlink {display:none;} to OpacUserCSS.

12 years agoBug 8211: Add exploded search options
Jared Camins-Esakov [Thu, 23 Aug 2012 23:35:22 +0000 (19:35 -0400)]
Bug 8211: Add exploded search options

When working with hierarchical subject headings, it is sometimes helpful
to do a search for all records with a specific subject, plus
broader/narrower/related subjects. This patch adds support for these
"exploded" subject searches to Koha.

To test:
1) Make sure you have a bunch of hierarchical subjects. I created
   geographical subjects for "Arizona," "United States," and "Phoenix,"
   and linked them together using 551s, and made sure I had a half
   dozen records linking to each (but not all to all three).
2) Do a search for su-br:Arizona (or choose "Subject and broader terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "United States"
3) Do a search for su-na:Arizona (or choose "Subject and narrower terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona" and the
   records with the subject "Phoenix"
4) Do a search for su-rl:Arizona (or choose "Subject and related terms"
   on the advanced search screen with "more options" displayed), and
   check that you get the records with the subject "Arizona," the
   records with the subject "United States," and the records with the
   subject "Phoenix"
5) Ensure that other searches still work (keyword, subject, ccl,
   whatever)
6) Sign off

Technical details:
This patch adds a shim in front of C4::Search::buildQuery in order to
preprocess the query and call the _handle_exploding_search callback.
This shim will allow us to gradually offload query parsing to a new
query parser module.

Signed-off-by: wajasu <matted-34813@mypacks.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6151'
Paul Poulain [Tue, 18 Sep 2012 13:14:32 +0000 (15:14 +0200)]
Merge remote-tracking branch 'origin/new/bug_6151'

12 years agoBug 6151 follow-up fix POD
Paul Poulain [Tue, 18 Sep 2012 13:14:00 +0000 (15:14 +0200)]
Bug 6151 follow-up fix POD

Fixing POD, problem detected by jenkins (thanks jenkins !)

12 years agoBug 8597 follow-up DBRev number
Paul Poulain [Tue, 18 Sep 2012 12:39:00 +0000 (14:39 +0200)]
Bug 8597 follow-up DBRev number

12 years agoBug 8597: Add system preferences to configure the mobile view.
Frédérick [Mon, 13 Aug 2012 16:29:35 +0000 (12:29 -0400)]
Bug 8597: Add system preferences to configure the mobile view.

This patch adds the following system preferences:
* OpacMainUserBlockMobile - alternate content for the MainUserBlock for
  mobile
* OPACMobileUserCSS - custom CSS for mobile views only
* OpacShowFiltersPulldownMobile - whether or not to show the index
  dropdown on the mobile view
* OpacShowLibrariesPulldownMobile - whether or not to show the library
  dropdown on the mobile view

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 8597: Add CSS, JS, and images to ccsr theme
Jared Camins-Esakov [Mon, 13 Aug 2012 00:04:19 +0000 (20:04 -0400)]
Bug 8597: Add CSS, JS, and images to ccsr theme

In order for themes to work, they must include all CSS, Javascript, and
image assets that they use. This patch adds all CSS, Javascript, and
images from the prog theme to ccsr, EXCEPT for the famfamfam image set,
which needs to be moved outside of the theme directories, per bug 8624.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8597: fix hardcoded references to prog in ccsr
Jared Camins-Esakov [Sun, 12 Aug 2012 23:24:07 +0000 (19:24 -0400)]
Bug 8597: fix hardcoded references to prog in ccsr

There were a few hardcoded references to the prog theme in the new
ccsr theme's files.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8597: Add mobile functionality to ccsr theme
Frederick Capovilla [Sun, 12 Aug 2012 22:32:45 +0000 (18:32 -0400)]
Bug 8597: Add mobile functionality to ccsr theme

This patch adds the promised media query-based mobile view to the
ccsr theme. You can try the mobile view by resizing your browser window
until it is phone-sized.

Sponsored-by: Centre collégial des services regroupés (CCSR)
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
All work was originally done by Frederick, but I converted his
modifications to the prog template into a new template called ccsr.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8597: Create new CCSR theme
Frederick Capovilla [Sun, 12 Aug 2012 22:28:02 +0000 (18:28 -0400)]
Bug 8597: Create new CCSR theme

Creates a new theme for the OPAC called "ccsr." The new theme has a much
cleaner, more modern look than the prog theme, and is designed from the
ground up to work on mobile devices using media queries. A later patch
will include the mobile view.

In order to activate the theme, change the opacthemes syspref to 'ccsr'
and make sure that your opaccolorstylesheet is set to 'colors.css.'

Sponsored-by: Centre collégial des services regroupés (CCSR)
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
All work was originally done by Frederick, but I converted his
modifications to the prog template into a new template called ccsr.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 8597: Improve template markup to prepare for mobile
Frederick Capovilla [Mon, 13 Aug 2012 00:06:30 +0000 (20:06 -0400)]
Bug 8597: Improve template markup to prepare for mobile

The templates were missing classes on a number of elements that
will need classes in order for a mobile view to function.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years ago8627 Followup for removing tabs
Marcel de Rooy [Mon, 13 Aug 2012 08:57:36 +0000 (10:57 +0200)]
8627 Followup for removing tabs

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
12 years ago8627 Fixing pipe values in controlfield 008 authorities
Marcel de Rooy [Mon, 13 Aug 2012 08:28:45 +0000 (10:28 +0200)]
8627 Fixing pipe values in controlfield 008 authorities

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
12 years agoBug 8693 - Sort biblio checkout history by checkout date instead of patron name
Owen Leonard [Tue, 28 Aug 2012 13:25:52 +0000 (09:25 -0400)]
Bug 8693 - Sort biblio checkout history by checkout date instead of patron name

Adding a default sort on checkout date.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 8757 follow-up DBRev number
Paul Poulain [Tue, 18 Sep 2012 10:25:01 +0000 (12:25 +0200)]
bug 8757 follow-up DBRev number

12 years agoBug 8757: longer descriptions for authorised values
Adrien Saurat [Tue, 11 Sep 2012 09:16:29 +0000 (11:16 +0200)]
Bug 8757: longer descriptions for authorised values

In the "suggestions" table, the "lib" and "lib_opac" sizes
has been raised from 80 chars to 200.
The GUI allowing the authorised values creation/update has
been changed accordingly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4321: clean C4::Biblio::GetBiblio and uses
Jonathan Druart [Tue, 24 Jul 2012 13:39:15 +0000 (15:39 +0200)]
Bug 4321: clean C4::Biblio::GetBiblio and uses

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8709: Subfield 0 does not show in MARC detail in intranet
Fridolyn SOMERS [Fri, 31 Aug 2012 14:02:27 +0000 (16:02 +0200)]
Bug 8709: Subfield 0 does not show in MARC detail in intranet

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8717 - Wrong subscription notes are showing in catalogue detail view of serials...
David Cook [Tue, 4 Sep 2012 02:19:41 +0000 (12:19 +1000)]
Bug 8717 - Wrong subscription notes are showing in catalogue detail view of serials in staff client

Changes the subscription note from the opac "notes" to the proper staff client "internalnotes" field.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 3782: Remove broken z39.50 targets from sample files
Katrin Fischer [Wed, 22 Aug 2012 20:33:26 +0000 (22:33 +0200)]
Bug 3782: Remove broken z39.50 targets from sample files

Removes NYPL and NYU from the list of sample z39.50 servers, because
they don't work or only work inconsistently.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8275: xml parsing error when the webservice GetPatronInfo/show_loans is called
Fridolyn SOMERS [Thu, 19 Jul 2012 09:37:16 +0000 (11:37 +0200)]
Bug 8275: xml parsing error when the webservice GetPatronInfo/show_loans is called

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8336 follow-up, tabs to space
Paul Poulain [Tue, 18 Sep 2012 09:23:42 +0000 (11:23 +0200)]
Bug 8336 follow-up, tabs to space

12 years agoBug 8336 Support Sip Renewal Transaction
Colin Campbell [Fri, 29 Jun 2012 17:43:28 +0000 (18:43 +0100)]
Bug 8336 Support Sip Renewal Transaction

Renewals were being rejected for incorrect reasons
Checking was being done against the wrong object
Add more informative messages on failure
Correctly set due_date for renewal response
Avoid crashing the SIPServer because it handles RenewAll
incorrectly

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6151 follow-up, fix HTML4 coding guideline
Paul Poulain [Mon, 17 Sep 2012 17:24:45 +0000 (19:24 +0200)]
Bug 6151 follow-up, fix HTML4 coding guideline

12 years agoBug 6151 - Followup - Change 'itemnumber' to 'barcode'
Kyle M Hall [Mon, 13 Aug 2012 20:02:04 +0000 (16:02 -0400)]
Bug 6151 - Followup - Change 'itemnumber' to 'barcode'

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
12 years agoBug 6151 - Followup - Display message for failed returns on circulation.pl when retur...
Kyle M Hall [Thu, 2 Aug 2012 12:23:50 +0000 (08:23 -0400)]
Bug 6151 - Followup - Display message for failed returns on circulation.pl when returning via issues table.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoBug 6151 follow-up DBREv & removing useless `
Paul Poulain [Mon, 17 Sep 2012 17:18:59 +0000 (19:18 +0200)]
Bug 6151 follow-up DBREv & removing useless `

12 years agoBug 6151: Add AllowReturnToBranch system preference
Ian Walls [Thu, 1 Dec 2011 21:15:04 +0000 (16:15 -0500)]
Bug 6151: Add AllowReturnToBranch system preference

In order to solve the issue of IndependantBranches being incompatible with HomeOrHoldingBranchReturn,
this patch changes the mechanism by which the question "can I return this material here?" is answered.  Before,
the conditions were "if IndependantBranches is on, and this branch isn't HomeOrHoldingBranchReturn for the item,
then no, otherwise yes".  Now, the question is answered by consulting CanBookBeReturned (new subroutine)

New system preference:  AllowReturnToBranch
Possible values:
  - anywhere (default for new installs, and for existing systems with IndependantBranches turned off)
  - homebranch
  - holdingbranch (which is also the issuing branch in all normal circumstances)
  - homeorholdingbranch (default for existing systems with IndependantBranches turned on)

New subroutine:  CanBookBeReturned
Input:  $item hash (from GetItems), and $branchcode
Output: 0 or 1 to indicate "allowed" or not, and an optional message if not allowed.  Message is the 'correct' branchcode
to return the material to

To Test:
1.  Install patch and new syspref
2.  Check that default value of the preference:
    - if IndependantBranches was OFF at install time, should be 'anywhere'
    - if IndependantBranches was ON at install time, should be 'homeorholdingbranch'

Case:  'anywhere'
1.  Checkout a Library A book at Library A.  Return at Library A should be successful
2.  Repeat step 1, returning to Library B.  Return should be successful
3.  Checkout a Library A book at Library B.  Return to A should be successful
4.  Repeat step 3 with Library B and Library C

Case: 'homebranch'
1.  Checkout a Library A book at Library A.  Return at Library A should be successful
2.  Repeat step 1, returning to Library B.  Return should FAIL (returning message to return at A)
3.  Checkout a Library A book at Library B.  Return to Library A should be successful
4.  Repeat step 3 with Library B and Library C.  Both should FAIL (returning message to return at A)

Case: 'holdingbranch'
1.  Checkout a Library A book at Library A.  Return at Library A should be successful
2.  Repeat step 1, returning to Library B.  Return should FAIL (returning message to return at A)
3.  Checkout a Library A book at Library B.  Return to A should FAIL (returning message to return at B)
4.  Repeat step 3 with Library B. Return should be successful
5.  Repeat step 3 with Library C. Return should FAIL (returning message to return at B)

Case: 'homeorholdingbranch'
1.  Checkout a Library A book at Library A.  Return at Library A should be successful
2.  Repeat step 1, returning to Library B.  Return should FAIL (returning message to return at A)
3.  Checkout a Library A book at Library B.  Return to A should be successful
4.  Repeat step 3 with Library B. Return should be successful
5.  Repeat step 3 with Library C. Return should FAIL (returning message to return at A)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agoBug 8765 follow-up replace tabs by spaces
Paul Poulain [Mon, 17 Sep 2012 17:00:05 +0000 (19:00 +0200)]
Bug 8765 follow-up replace tabs by spaces

12 years agoBug 8765 - Add series title to intranet search results
David Cook [Wed, 12 Sep 2012 21:00:13 +0000 (07:00 +1000)]
Bug 8765 - Add series title to intranet search results

Patch adds series title to intranet search results, so that the
series volume is no longer displayed on its own.

It also removes the comma that comes before the series volume as
this is unnecessary punctuation that creates duplicate punctuation
in search results.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8713 - Warning message triggered by clicking Keywords to MARC mapping
Mark Tompsett [Mon, 3 Sep 2012 03:00:32 +0000 (11:00 +0800)]
Bug 8713 - Warning message triggered by clicking Keywords to MARC mapping

In the Koha Administration screen, clicking
Keywords to MARC mapping triggered an uninitialized $op warning
in the koha error logs. Added a "|| q{}" to ensure it is set.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8727 Minor stylistic change to help text
Colin Campbell [Wed, 5 Sep 2012 13:03:13 +0000 (14:03 +0100)]
Bug 8727 Minor stylistic change to help text

indexing not indexation
some minor grammatical changes

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7690: hidelostitems not working in Normal Display
Fridolyn SOMERS [Thu, 9 Aug 2012 10:43:20 +0000 (12:43 +0200)]
Bug 7690: hidelostitems not working in Normal Display

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Tested by toggling both the hidelostitems preference and the
OpacHiddenItems preference. Both work as expected in the normal
search results display.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8714 - Poorly ordered and triggers warning in marctagstructure.pl
Mark Tompsett [Mon, 3 Sep 2012 04:27:58 +0000 (12:27 +0800)]
Bug 8714 - Poorly ordered and triggers warning in marctagstructure.pl

An array boundary check was after a comparison using the array.
By changing the logic which had " and ( $j < $cnt)" to be at the
beginning "( $j < $cnt ) and ", the warning is no longer shown
in the error log.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8705: Software error on help of main page
Fridolyn SOMERS [Thu, 30 Aug 2012 16:42:26 +0000 (18:42 +0200)]
Bug 8705: Software error on help of main page

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4491: FIX buildQuery if called with an empty limit
Jonathan Druart [Wed, 22 Aug 2012 12:12:09 +0000 (14:12 +0200)]
Bug 4491: FIX buildQuery if called with an empty limit

if @limit=('') buildQuery failed

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
All searches that I tried (keyword, indexed, CCL, with limits, without,
etc.) worked fine. There are warnings about uninitialized variables in
the OPAC, but they exist on master as well and therefore should not
block these patches.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4491: fix weird code in search scripts
Jonathan Druart [Tue, 24 Jul 2012 14:16:16 +0000 (16:16 +0200)]
Bug 4491: fix weird code in search scripts

This change some code a bit strange, that generate strange effetcs.
Now we use $cgi->param to get the values.

Test: search at the opac and intranet using limit, etc.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
12 years agoBug 7991: Add itemcallnumber into the serial collection tab
Jonathan Druart [Thu, 3 May 2012 12:58:25 +0000 (14:58 +0200)]
Bug 7991: Add itemcallnumber into the serial collection tab

This patch adds a new column containing the itemcallnumber value into
the serial collection tab (opac detail).
  930$a for UNIMARC
  852$h for others

Signed-off-by: Stephane Delaye <stephane.delaye@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
(Added Stephane Delaye's sign off at the same time as mine)
As this view has never worked with MARC21, I am comfortable signing
off on the fact that the patch does not in any way impact the MARC21
display.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 8617 - Problem with display of comments waiting for moderation in OPAC
Owen Leonard [Thu, 16 Aug 2012 19:19:04 +0000 (15:19 -0400)]
Bug 8617 - Problem with display of comments waiting for moderation in OPAC

This patch addresses on aspect of Bug 8617: The behavior where
live previews of edited comments are displaying on opac-detail
as a duplicate comment. We must pass the review id back to the
script when submitting so that the check for it will evaluate
as true when it should.

This patch also corrects some JavaScript for translatability.

To test, submit a comment on a title and approve it. Return to
the title and edit the comment. When you submit your revised
comment the comment pop-up window should close and your revised
comment should appear on opac-detail as "pending approval."

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7671'
Paul Poulain [Sat, 15 Sep 2012 05:35:25 +0000 (07:35 +0200)]
Merge remote-tracking branch 'origin/new/bug_7671'

12 years agoBug 7671 follow-up DBRev number
Paul Poulain [Sat, 15 Sep 2012 05:34:06 +0000 (07:34 +0200)]
Bug 7671 follow-up DBRev number

12 years agoBug 7671 : add a real primary key accountlines_id in accountlines
Stéphane Delaune [Fri, 9 Mar 2012 09:39:30 +0000 (10:39 +0100)]
Bug 7671 : add a real primary key accountlines_id in accountlines

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Marc Veron <veron@veron.ch>
NOTE: After applying the patch I got following errors in members/pay.pl:
Global symbol "$writeoff_sth" requires explicit package name
Global symbol "$add_writeoff_sth" requires explicit package name

Added to lines at the begin of members/pay.pl:
our $writeoff_sth;
our $add_writeoff_sth;

Now the patch worked as expected.

However I am not quite sure if signing off is OK in this situation.

Marc

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
12 years agobug 8768 correct an error in ItemType.t
Colin Campbell [Thu, 13 Sep 2012 09:37:56 +0000 (10:37 +0100)]
bug 8768 correct an error in ItemType.t

The second test in ItemType.t tests that an empty table
returns no rows however as Mock::DBD has no resultset
it fails with an error in DBI It requires that an
empty resultset is defined in Mock::DBD first
This patch adds that mocked empty table

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agobug 8768 correct an error in ItemType.t
Colin Campbell [Thu, 13 Sep 2012 09:37:56 +0000 (10:37 +0100)]
bug 8768 correct an error in ItemType.t

The second test in ItemType.t tests that an empty table
returns no rows however as Mock::DBD has no resultset
it fails with an error in DBI It requires that an
empty resultset is defined in Mock::DBD first
This patch adds that mocked empty table

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>