]> git.koha-community.org Git - koha.git/log
koha.git
12 years agoBug 6790: Remove unnecessary variable from getroutinglist return
Colin Campbell [Fri, 26 Aug 2011 15:17:11 +0000 (16:17 +0100)]
Bug 6790: Remove unnecessary variable from getroutinglist return

getroutinglist returns a count variable to indicate how many elements
are in the array. This is almost always a serious code smell. (We are
programming in a list manipulating language) The routine was executing
am unnecessary loop just to maintain that var.
Removed the variable from the routine and perldoc
refactored calls of the routine removed the c-style loops for
more idiomatic and maintainable for loops
renamed some opaquely named variables
removed a call to the routine where nothing was done with the data
moved some html out of the calling script and into the template

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7402 : Fixing the date formatting so links to the invoice page work
Chris Cormack [Wed, 4 Jan 2012 19:54:43 +0000 (08:54 +1300)]
Bug 7402 : Fixing the date formatting so links to the invoice page work

This depends on bug 929

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Uses the new TT plugin to display the date, while using iso format
to build a correct URL to the invoice page.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5473 follow-up : removed warn & replace some tabs by 4 spaces
Paul Poulain [Fri, 20 Jan 2012 15:30:48 +0000 (16:30 +0100)]
Bug 5473 follow-up : removed warn & replace some tabs by 4 spaces

12 years agobug_5473: Update items when receiving shipments
Srdjan Jankovic [Tue, 20 Dec 2011 01:56:51 +0000 (14:56 +1300)]
bug_5473: Update items when receiving shipments

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Tested by recieving multiple items with the AcqCreateItem
preference set to 'placing and order' and 'receiving an item'
In both cases the pricing and vendor is brought over to the
item record so I'm signing off.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoUpdate CircAutoPrintQuickSlip description
Nicole C. Engard [Mon, 2 Jan 2012 13:40:55 +0000 (08:40 -0500)]
Update CircAutoPrintQuickSlip description

This patch simply removes the repeated string in the
description for this preference.

http://bugs.koha-community.org/show_bug.cgi?id=7429

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6694: Problem with casAuthentication syspref
Julian Maurice [Wed, 10 Aug 2011 09:41:06 +0000 (11:41 +0200)]
Bug 6694: Problem with casAuthentication syspref

A missing test in checkauth caused anonymous session to be destroyed and
re-created at every call when this syspref was set.
Almost the same issue is also fixed in check_api_auth, which caused
C4::Service->init to fail.

Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBZ6115: Acquisition reports : date filter & sorting don't work
Paul Poulain [Fri, 22 Jul 2011 08:24:26 +0000 (10:24 +0200)]
BZ6115: Acquisition reports : date filter & sorting don't work

* the filter on dates don't work
* when displaying by day or month, it was 100% alphabetic, april was before
january for example. Adding the month number before the month name to get
proper sorting
* removed many commented warn & lines

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoKoha version updated
Paul Poulain [Thu, 19 Jan 2012 15:48:54 +0000 (16:48 +0100)]
Koha version updated

12 years agoBug 5347: Followup change class for message + Unit test
Jonathan Druart [Tue, 17 Jan 2012 10:39:54 +0000 (11:39 +0100)]
Bug 5347: Followup change class for message + Unit test

12 years agoBug 5347: Set translatable the "no email" error
Jonathan Druart [Fri, 30 Dec 2011 09:34:03 +0000 (10:34 +0100)]
Bug 5347: Set translatable the "no email" error

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This bookseller has no email shows up correctly, when vendor has
no email address.

Small change made: Changed bookseller to vendor.

12 years agoBug 5347: Follow up - Fix warnings, check/uncheck all and makes error message transla...
Katrin Fischer [Fri, 30 Dec 2011 09:24:31 +0000 (10:24 +0100)]
Bug 5347: Follow up - Fix warnings, check/uncheck all and makes error message translatable

This patch fixes some minor problems found in late order management:

 1) Silences 2 warns in Letters.p
After patch is applied no more warns should show up in the logs.

 2) Fixes check/uncheck al
When limiting on one vendor the checkbox in the last header column
was doing nothing. I changed the checkbox to 2 links 'check all' and
'uncheck all' as it's done in other templates.

 3) Email has been sent
The message was hardcoded into the lateorders.pl file and not
translatable.
I moved it to the template and changed the wording slightly.

Note: The error message 'The bookseller has no email' comes from
Letters.pm. I didn't change that, because I was not sure where it is
used. The error message as is can not be translated and should be
moved into the templates too.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5347: Followup Adds columns claims_count and claimed_date in aqorders
Jonathan Druart [Wed, 28 Dec 2011 08:44:39 +0000 (09:44 +0100)]
Bug 5347: Followup Adds columns claims_count and claimed_date in aqorders

FIX encoding problem

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Umlauts and diacritics now show up correctly in generated claims notices.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5347: Adds columns claims_count and claimed_date in aqorders
Jonathan Druart [Fri, 2 Dec 2011 13:03:50 +0000 (14:03 +0100)]
Bug 5347: Adds columns claims_count and claimed_date in aqorders

This patch adds 2 columns in the aqorders table :
- claims_count : number of claims for an orders
- claimed_date : date of the lastest claim

In the lateorders.pl table, you can not select orders from different
supplier because there is just one letter sent after clicking the "Claim
order" button. So, it's logic that you want to select only orders from
this supplier.

Modification in C4/Letters.pm:
refactoring code for claimacquisition and claimissues letter type.
Now, fields for theses letters check the table name. It's not possible
to chooce aqorders.title, this field doesn't exist !
Furthermore, you can add a <order> tag around your item fields, like
this :

-- Begin example
<<LibrarianFirstname>>
<<LibrarianSurname>>

<<aqbooksellers.contact>>
<<aqbooksellers.address1>>
<<aqbooksellers.phone>>
<<aqbasket.basketno>>
<<aqbooksellers.phone>>
<order>Library : <<items.homebranch>>
In your possesssion : <<biblio.author>>. <<biblio.title>>.
<<biblioitems.publishercode>>, <<biblioitems.publicationyear>>.
Callnumber : <<items.itemcallnumber>>. doc type : <<items.itype>>
Barcode : <<items.barcode>>
Date for the return : <<items.onloan>>.</order>

<<LibrarianSurname>>
-- End example

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoOlivier Crouzet is 168th !
Paul Poulain [Thu, 19 Jan 2012 16:02:43 +0000 (17:02 +0100)]
Olivier Crouzet is 168th !

12 years agoMerge remote-tracking branch 'origin/new/bug_6328'
Paul Poulain [Thu, 19 Jan 2012 15:50:49 +0000 (16:50 +0100)]
Merge remote-tracking branch 'origin/new/bug_6328'

12 years agoBug 6328 follow-up, fixes Undefined subroutine &C4::Circulation::Delta_Days
Lyon3 Team [Thu, 19 Jan 2012 15:44:01 +0000 (16:44 +0100)]
Bug 6328 follow-up, fixes Undefined subroutine &C4::Circulation::Delta_Days

The Delta_Days sub is called only when a patron that is already debarred must be debarred for a longer period.
This (rare) case probably hasn't be tested during QA, because the sub is not loaded.
Loading it fixes the problem

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7083'
Paul Poulain [Wed, 18 Jan 2012 15:20:26 +0000 (16:20 +0100)]
Merge remote-tracking branch 'origin/new/bug_7083'

12 years agoBZ4376 Minor change in GetMarcAuthor
Paul Poulain [Tue, 2 Aug 2011 14:54:38 +0000 (16:54 +0200)]
BZ4376 Minor change in GetMarcAuthor

A minor change in the GetMarcAuthors function of C4/Biblio.pm allow differentiate the type of authors in the templates

This change allow doing things like this in the templates:
<TMPL_IF EXPR="tag == 700" && code eq 'a' >
 <strong>Author:</strong>
<!-- TMPL_ELSE -->
 <TMPL_IF EXPR="tag == 710" && code eq 'a' >
  <strong>Corpotation Author:</strong>
<!-- /TMPL_IF -->
<!-- /TMPL_IF -->

(html template syntax, but also applicable to template toolkit)

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Works as claimed and doesn't break existing functionality.

12 years agoBug 7435: corrects Fund selectbox in addneworder
Adrien Saurat [Wed, 11 Jan 2012 15:28:02 +0000 (16:28 +0100)]
Bug 7435: corrects Fund selectbox in addneworder

Prevent disabled funds to appear in the Fund
select box.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7276'
Paul Poulain [Tue, 17 Jan 2012 17:14:03 +0000 (18:14 +0100)]
Merge remote-tracking branch 'origin/new/bug_7276'

12 years agoBug 7276 : Follow up, adding a sub to clear the cache
Chris Cormack [Tue, 6 Dec 2011 22:07:23 +0000 (11:07 +1300)]
Bug 7276 : Follow up, adding a sub to clear the cache

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7276 : member entry Performance improvement
Henri-Damien LAURENT [Tue, 29 Nov 2011 09:57:14 +0000 (10:57 +0100)]
Bug 7276 : member entry Performance improvement

Before this patch : 9619 borrowers added in 31 Minutes, After : 68 seconds.
This adds Hashref to table structure in C4::SQLHelper to speed up bulk edits.

Signed-off-by: Stéphane Delaune <stephane.delaune@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6885 Follow up patch, invert tested condition
Frédéric Demians [Wed, 4 Jan 2012 17:09:34 +0000 (18:09 +0100)]
Bug 6885 Follow up patch, invert tested condition

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Not sure the brackets are nessecary, but I think I remember learning
bitwise operators have a lower priority than other relational
operators so wanted to make sure we notted the result of the bitwise
and, not the flag

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7266: flags debarred, suspended, gonenoaddress in overdue
Adrien Saurat [Tue, 20 Dec 2011 08:33:47 +0000 (09:33 +0100)]
Bug 7266: flags debarred, suspended, gonenoaddress in overdue

This patch makes these flags functionnal.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7097: HidePatronName not hiding on issue history
Ian Walls [Thu, 5 Jan 2012 18:17:53 +0000 (13:17 -0500)]
Bug 7097: HidePatronName not hiding on issue history

HidePatronName wasn't being respected on a titles Checkout History tab.  This patch
exports the preference to the template (if set), and then toggles the display between
patron cardnumber (if 'on') or the name (if 'off')

To test:

Enable HidePatronName
Go to the Checkout History tab of an item that has been checked out before
You should see the patron's cardnumber instead of their surname, firstname

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7388 [SIGNED-OFF] [enh] - round the corners on the side menus in the staff client
Liz Rea [Fri, 30 Dec 2011 06:36:08 +0000 (00:36 -0600)]
Bug 7388 [SIGNED-OFF] [enh] - round the corners on the side menus in the staff client

To test:
apply patch
check menus on circulation and bib detail page - corners on the menus to the left should be rounded.

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Those rounded corners do look more friendly. I have tested circulation and bib detail page and
have found no ill side effects.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7399: Holds Queue should show reserve notes
Ian Walls [Tue, 3 Jan 2012 17:00:26 +0000 (12:00 -0500)]
Bug 7399: Holds Queue should show reserve notes

The notes for a specific hold, if they existed, were being added to the tmp_holdsqueue
table by build_holds_queue.pl, but they were not displayed anywhere, which seems a waste.

This patch adds the Notes column to the far right of view_holdsqueue.pl.

To Test:

Place a hold with a note
Run build_holds_queue.pl to place it in the Holds Queue
View the Holds Queue; you should see the note on the far right of the table

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7332: Translated title (MARC21 242) not shown
Jared Camins-Esakov [Thu, 8 Dec 2011 14:18:37 +0000 (09:18 -0500)]
Bug 7332: Translated title (MARC21 242) not shown

The cataloger-supplied translated title stored in MARC21 field 242 was not being
displayed when XSLT was enabled.

Test plan:
1) Enable XSLT for OPAC Details and Results, and Intranet Details.
2) Create or add a record with a 242 field
3) See that the translated title is not displayed in OPAC Details or Results, or
Intranet Details
4) Apply patch
5) See that the translated title is now displayed in OPAC Details and Results,
and Intranet Details

Signed-off-by: Duncan Tyler <duncan@duncan-SoT.wgtn.cat-it.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6787 - Fast Add framework for NORMARC
Magnus Enger [Tue, 27 Dec 2011 21:49:33 +0000 (22:49 +0100)]
Bug 6787 - Fast Add framework for NORMARC

The new framework will be called "Hurtigkatalogisering".

To test:
- Make sure the nb-NO translation is installed
- Run through the web installer on an empty database
- Select nb-NO as the installation language
- Select NORMARC as the marcflavour
- Include normarc_fastadd_framework in the installed data
- Check that the framework looks ok in:
-- More > Cataloguing
-- More > Administration > MARC framework

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, not problems found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7277: Fixes display of subtitles in opac.
Garry Collum [Sun, 15 Jan 2012 22:00:12 +0000 (17:00 -0500)]
Bug 7277: Fixes display of subtitles in opac.

Adds comma and space to results display in opac between title and subtitles.
Also removes extra space before the subtitle in the results display of the staff pac.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 4300: Fix display of textual holdings (866)
Katrin Fischer [Mon, 16 Jan 2012 22:05:42 +0000 (23:05 +0100)]
Bug 4300: Fix display of textual holdings (866)

Fixed problems:
- only $z, but not $a was shown
- only first $z for each 866 field was shown
- each 866 field produced a ; even if no $z was present

After patch was applied:
- OPAC displays 866 $a and $z, separating each field with ;
- Staff displays 866 $a, $x and $z, separating each field with ;

Example(s) for testing:
866 $a1-86 (1941-1987)$xbound in 2 v. per year$zSome issues missing
866 $a1-86 (1941-1987)
866 $a--86 (1941-1897)$xinternal note
866 $zfirst note,$zsecond note

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7006, highlight patron changes in email
Owen Leonard [Tue, 11 Oct 2011 19:56:10 +0000 (15:56 -0400)]
Fix for Bug 7006, highlight patron changes in email

This patch eliminates all unchanged fields from the email
on the assumption that the information is superfluous. I have
also added a link to the patron edit screen which will be
displayed if the staffClientBaseURL has been entered.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7247 - rebuild_zebra.pl -v should show all Zebra log output
Dobrica Pavlinusic [Sat, 19 Nov 2011 10:49:53 +0000 (11:49 +0100)]
Bug 7247 - rebuild_zebra.pl -v should show all Zebra log output

Currently, -v option resets Zebra log output to default system values.

This produce amount of log specified in system defaults which is usually
too low for debugging.

This change explicitly forces all Zebra log output which create much more
chatter so it triggers with verbosity level 2

Test scenario:
1. pick koha site to reindex
2. use -v -v options to rebuild_zebra.pl to see additional output

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Verified help corrections and  loglevel 2 output vs. loglevel 1 output. No issues found.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6466 - hung socket read causes SIP tests to fail
JAMES Mason [Mon, 6 Jun 2011 04:10:39 +0000 (16:10 +1200)]
Bug 6466 - hung socket read causes SIP tests to fail

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7357: display serial title instead of '---'
Adrien Saurat [Mon, 9 Jan 2012 10:55:08 +0000 (11:55 +0100)]
Bug 7357: display serial title instead of '---'

The full title of a serial is now displayed even
if several lines have the same title.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5533'
Paul Poulain [Tue, 17 Jan 2012 15:03:14 +0000 (16:03 +0100)]
Merge remote-tracking branch 'origin/new/bug_5533'

12 years agoBug 5533 followup: reinstate Lost status editing
Ian Walls [Thu, 15 Dec 2011 13:21:56 +0000 (08:21 -0500)]
Bug 5533 followup: reinstate Lost status editing

The original patch for 5533 removed the Lost status from the edit items screen; new items were not affected,
and batch changes could still be made, so this was not a consistent change.

This patch removes the filter that hid the Lost status dropdown, but then changes the default MARC framework
to hide this field by default (value -5).  New installations will not see this status in the editor, unless
they manually activate it.  This will enforce the semantics of using the "mark lost" options by default, but
provide a workaround for libraries that understand and accept the consequences of manually editing this field.

To test:

1.  on an existing install, edit an item.  you should have the Lost status visible
2.  on a new install, editing or creating an item should not show the Lost status at all

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7407: HidePatronName not working on 'on hold for' messages
Ian Walls [Thu, 5 Jan 2012 19:10:52 +0000 (14:10 -0500)]
Bug 7407: HidePatronName not working on 'on hold for' messages

HidePatronName was not working on 'on hold for' messages, only 'checked out to'
messages.  This resulted in the patrons name showing if the item was on hold for
them.

T:T scope issue; needs to be within itemloo.  This patch does that.
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_5327'
Paul Poulain [Tue, 17 Jan 2012 14:35:19 +0000 (15:35 +0100)]
Merge remote-tracking branch 'origin/new/bug_5327'

12 years agobug 5327 add tests for C4/BackgroundJob.pm
Sam Sanders [Tue, 17 Jan 2012 02:37:59 +0000 (15:37 +1300)]
bug 5327 add tests for C4/BackgroundJob.pm

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl t/db_dependent/BackgroundJob.t
All tests complete successfully.

Note: Test 11 does not tell what it's about, but it has been there before.

12 years agoBug 5327 Added unit tests for C4/Reports.pm
Connor Dewar [Tue, 17 Jan 2012 02:40:25 +0000 (15:40 +1300)]
Bug 5327 Added unit tests for C4/Reports.pm

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl t/Reports.t b/t/Reports.t
All tests complete successfully.

12 years agoBug 5327 Added unit tests for C4/ClassSortRoutine/Dewey.pm
Connor Dewar [Tue, 17 Jan 2012 01:32:29 +0000 (14:32 +1300)]
Bug 5327 Added unit tests for C4/ClassSortRoutine/Dewey.pm

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5327 added unit tests for C4/ClassSortRoutine/Generic
Connor Dewar [Tue, 17 Jan 2012 00:55:03 +0000 (13:55 +1300)]
Bug 5327 added unit tests for C4/ClassSortRoutine/Generic

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoMerge remote-tracking branch 'origin/new/bug_6990'
Paul Poulain [Tue, 17 Jan 2012 14:07:09 +0000 (15:07 +0100)]
Merge remote-tracking branch 'origin/new/bug_6990'

12 years agoBug 6990 follow up PODDOC & unit test updating
Paul Poulain [Mon, 16 Jan 2012 17:47:15 +0000 (18:47 +0100)]
Bug 6990 follow up PODDOC & unit test updating

This patch removes the TransformKohaToMarcOneField sub, but there was some remaining POD & unit test about it

12 years agoTransformKohaToMarc enhancement
Frédéric Demians [Sat, 8 Oct 2011 15:03:18 +0000 (17:03 +0200)]
TransformKohaToMarc enhancement

TransformKohaToMarc function is called for each biblio and item that has
to be build. This function execute a DB statement for each Koha field
that has to be mapped to a MARC tag/letter. This impact deeply
performances for script like rebuild_zebra, especially since items are
not anymore in bilio records and have to be rebuild on the fly.

I'm proposing a patch which read Koha field to MARC field mapping just
one time and cache it. My test show a 30% execution time improvement on
rebuild_zebra.pl script. It uses already cached mapping in C4::Context.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
http://bugs.koha-community.org/show_bug.cgi?id=6990
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7364'
Paul Poulain [Tue, 17 Jan 2012 11:05:00 +0000 (12:05 +0100)]
Merge remote-tracking branch 'origin/new/bug_7364'

Conflicts:
cataloguing/additem.pl

12 years agoBug 7364: Possible to get to FA item add without current branch being defined.
D Ruth Bavousett [Fri, 16 Dec 2011 15:38:47 +0000 (10:38 -0500)]
Bug 7364: Possible to get to FA item add without current branch being defined.

Some paths to the FA item-add screen didn't have a branch defined--if the param is set,
use it, otherwise, use the user's logged in branch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Modified for syntax by:  Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
12 years agoRevert "Bug 7364: Possible to get to FA item add without current branch being defined."
Paul Poulain [Tue, 17 Jan 2012 08:32:21 +0000 (09:32 +0100)]
Revert "Bug 7364: Possible to get to FA item add without current branch being defined."

This reverts commit 6f681bec2d71d3d2b88aea5f8e0c15010241d580.

12 years agoRevert "Bug 7364: Possible to get to FA item add without current branch being defined."
Paul Poulain [Mon, 16 Jan 2012 17:58:10 +0000 (18:58 +0100)]
Revert "Bug 7364: Possible to get to FA item add without current branch being defined."

This reverts commit 6f681bec2d71d3d2b88aea5f8e0c15010241d580.

Reverting because on my test server, I get

syntax error at /home/paul/koha.dev/koha-community/cataloguing/additem.pl line
668, near "->param{"
Execution of /home/paul/koha.dev/koha-community/cataloguing/additem.pl aborted
due to compilation errors.

12 years agoMerge remote-tracking branch 'origin/new/bug_929'
Paul Poulain [Mon, 16 Jan 2012 17:19:38 +0000 (18:19 +0100)]
Merge remote-tracking branch 'origin/new/bug_929'

12 years agoBug 929 : Follow up to allow tests to check plugins too
Chris Cormack [Fri, 13 Jan 2012 18:28:11 +0000 (07:28 +1300)]
Bug 929 : Follow up to allow tests to check plugins too

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
perl xt/author/valid-templates.t runs without errors now.

12 years agoBug 7364: Possible to get to FA item add without current branch being defined.
D Ruth Bavousett [Fri, 16 Dec 2011 15:38:47 +0000 (10:38 -0500)]
Bug 7364: Possible to get to FA item add without current branch being defined.

Some paths to the FA item-add screen didn't have a branch defined--if the param is set,
use it, otherwise, use the user's logged in branch.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_7143'
Paul Poulain [Mon, 16 Jan 2012 14:05:49 +0000 (15:05 +0100)]
Merge remote-tracking branch 'origin/new/bug_7143'

12 years agoBug 7143: add Albert Oller to the about.tt
Jesse Maseto [Fri, 13 Jan 2012 23:34:00 +0000 (18:34 -0500)]
Bug 7143: add Albert Oller to the about.tt

Albert Oller was in the doc/history.txt but not the About page.
adding him alphabetically

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6947 : opac-topissues.pl wasn't respecting item live itemtypes
Chris Cormack [Fri, 28 Oct 2011 19:49:20 +0000 (08:49 +1300)]
Bug 6947 : opac-topissues.pl wasn't respecting item live itemtypes

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
The search was only looking for bib level itypes independent
from the settings for item-level_itypes.

After patch the system preference setting is respected
and search works accordingly.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6132'
Paul Poulain [Mon, 16 Jan 2012 13:53:08 +0000 (14:53 +0100)]
Merge remote-tracking branch 'origin/new/bug_6132'

12 years agoBug 6132: Add unit test for system preferences
Julian Maurice [Mon, 2 Jan 2012 09:49:28 +0000 (10:49 +0100)]
Bug 6132: Add unit test for system preferences

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6132: Update sysprefs cache in set_preference
Julian Maurice [Mon, 2 Jan 2012 09:45:55 +0000 (10:45 +0100)]
Bug 6132: Update sysprefs cache in set_preference

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
12 years agoMerge remote-tracking branch 'origin/new/bug_929'
Paul Poulain [Fri, 13 Jan 2012 16:47:30 +0000 (17:47 +0100)]
Merge remote-tracking branch 'origin/new/bug_929'

12 years agoBug 929 small follow-up (mistake in POD)
Paul Poulain [Fri, 13 Jan 2012 16:47:16 +0000 (17:47 +0100)]
Bug 929 small follow-up (mistake in POD)

12 years agoBug 929 : Follow up adding unit tests, discovered C4::Dates cached the syspref with...
Chris Cormack [Thu, 12 Jan 2012 08:23:21 +0000 (21:23 +1300)]
Bug 929 : Follow up adding unit tests, discovered C4::Dates cached the syspref with no way to clear it, fixed also.

12 years agoBug 929: Follow up adding the Koha:: namespace to the list of modules to test
Chris Cormack [Thu, 12 Jan 2012 07:16:52 +0000 (20:16 +1300)]
Bug 929: Follow up adding the Koha:: namespace to the list of modules to test

12 years agoBug 7240: Cleaning up import tables and action_logs
Marcel de Rooy [Mon, 21 Nov 2011 11:21:11 +0000 (12:21 +0100)]
Bug 7240: Cleaning up import tables and action_logs

This patch lets cleanup_database also purge older records from the (five) import tables and the action_logs table.
Two new command line parameters are introduced: --import and --logs.
If no number of days is specified for --zebraqueue, --import or --logs, it defaults to 30 days, 60 days resp. 180 days.
I did not add a default for --sessdays, because this parameter cannot be seen separately from parameter --sessions.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Adds new parameters and code, does not change existing behaviour

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7396: Debarred message not showing over SIP2
Ian Walls [Mon, 2 Jan 2012 16:06:13 +0000 (11:06 -0500)]
Bug 7396: Debarred message not showing over SIP2

Corrects typo in list of flags; was DEBARRED, but the actual name of the flag is
DBARRED (for some reason)

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7381 - wrong isbn showing on the staff search results
Owen Leonard [Tue, 27 Dec 2011 19:46:54 +0000 (14:46 -0500)]
Bug 7381 - wrong isbn showing on the staff search results

Outputting the "raw" ISBN. In the case of multiples, ISBNs
are concatenated with " | " Using a T:T filter to make these
a comma-separated list.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Added a record and confirmed that the right ISBN shows on the
search results and that the amazon cover image still works.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7363: allows downloading of lists in CSV format
Adrien Saurat [Fri, 16 Dec 2011 15:51:18 +0000 (16:51 +0100)]
Bug 7363: allows downloading of lists in CSV format

Getting a list in CSV format was impossible because the
shelfid parameter was empty in the URL.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7360 Import Default framework into other deletes default Framework
Admin User Koha [Wed, 14 Dec 2011 16:31:00 +0000 (17:31 +0100)]
Bug 7360 Import Default framework into other deletes default Framework

Step to reproduce :
- export default framework as SQL
- create new framework
- Import the exported SQL file into this new framework.
Go to default framework :
It disappeared.

If some libraries want to share default frameworks, then it is a major bug.
This patch fixes the test in order to cope with 0 character framework name.

Signed-off-by: François Charbonnier <francois.charbonnier@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7356 - Fix various typos and mis-spellings
Marc Balmer [Sun, 11 Dec 2011 18:00:14 +0000 (19:00 +0100)]
Bug 7356 - Fix various typos and mis-spellings

Fix typos: the the -> the, wether -> whether, developper -> developer.

http://bugs.koha-community.org/show_bug.cgi?id=7356
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_6716'
Paul Poulain [Fri, 13 Jan 2012 10:46:21 +0000 (11:46 +0100)]
Merge remote-tracking branch 'origin/new/bug_6716'

12 years ago6717 Documenting need_merge_authorities table
Marcel de Rooy [Thu, 20 Oct 2011 07:25:23 +0000 (09:25 +0200)]
6717 Documenting need_merge_authorities table

Documentation only.

http://bugs.koha-community.org/show_bug.cgi?id=6716
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agobug6716 - document the aqbooksellers table
Nicole C. Engard [Wed, 28 Sep 2011 12:05:29 +0000 (08:05 -0400)]
bug6716 - document the aqbooksellers table

This documents the table that stores vendor info in Koha.

There were 4 unused fields found:
  `accountnumber`
  `othersupplier`
  `currency`
  `booksellerurl`

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Accountnumber is no longer unused and can be managed.

12 years agoBug 7348 - Fixed error for serial toolbar buttons in IE7
Duncan Tyler [Tue, 13 Dec 2011 03:42:17 +0000 (16:42 +1300)]
Bug 7348 - Fixed error for serial toolbar buttons in IE7

http://bugs.koha-community.org/show_bug.cgi?id=7348
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7375 - Update minimum version of Perl to 5.10
Magnus Enger [Thu, 22 Dec 2011 09:20:44 +0000 (10:20 +0100)]
Bug 7375 - Update minimum version of Perl to 5.10

- Change the installer script to look for at least 5.10/5.010000
- Change the template to ask for the correct version

To test:
- Run through the webinstaller on 5.10 or newer and check that there are
no errors.
- Ideally: Run through the webinstaller on an older version than 5.10 and
check that there *is* an error, asking for 5.10 or newer.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7373 - Add 5 new icons to Bridge Set
Nicole C. Engard [Fri, 16 Dec 2011 11:17:09 +0000 (06:17 -0500)]
Bug 7373 - Add 5 new icons to Bridge Set

This patch adds 5 new icons to the Bridge Set.
These icons are designed by the Erikson Institute
in Chicago, IL, USA.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7368: Correct spelling of merge authorities job in pref file.
Marcel de Rooy [Mon, 19 Dec 2011 12:46:31 +0000 (13:46 +0100)]
Bug 7368: Correct spelling of merge authorities job in pref file.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7367: Add space before display of languages.
Marcel de Rooy [Mon, 19 Dec 2011 12:25:42 +0000 (13:25 +0100)]
Bug 7367: Add space before display of languages.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I am a bit confused why it does not work without the &nbsp;
but patch fixes the display problem.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5226: Add 545 to es-ES and nb-NO
Jared Camins-Esakov [Mon, 9 Jan 2012 14:31:07 +0000 (09:31 -0500)]
Bug 5226: Add 545 to es-ES and nb-NO

Since the original patches for bug 5226 were submitted, two new translations
have been added to Koha: es-ES and nb-NO. This patch adds the missing 545 line
to the frameworks for those languages.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 5226: Follow up to new/awaiting_qa/bug_5226
Katrin Fischer [Mon, 6 Dec 2010 17:39:38 +0000 (18:39 +0100)]
Bug 5226: Follow up to new/awaiting_qa/bug_5226

This patch adds the field definition to
- it-IT (default and sample frameworks)
- de-DE, en, fr-FR, pl-PL (sample frameworks)

I am not sure about the database update. If we want to do that, it should perhaps update all frameworks and languages.
At the moment only en and de-DE default frameworks are updated.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoAdd MARC21 field 545 to to framework fix bug 5226
Jared Camins-Esakov [Tue, 2 Nov 2010 03:08:24 +0000 (23:08 -0400)]
Add MARC21 field 545 to to framework fix bug 5226

Adds MARC21 field 545 to the English, French, German, and Polish MARC21
frameworks. The labels for the field still need to be translated into
French and Polish.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 6098 Followup -- doesn't replace NSB/NSE by space
Frédéric Demians [Fri, 13 May 2011 13:24:39 +0000 (15:24 +0200)]
Bug 6098 Followup -- doesn't replace NSB/NSE by space

On any page, NSB/NSE characters are replaced by space in Output.pm. It isn't a
good thing:

  - It isn't necessary since Zebra indexer handle properly those characters as
    delimiter.
  - It isn't necessary for display since XSL file already do that.
  - It isn't efficient since a regex is done on every whole page sent by Koha,
    not only on biblio record part.
  - It removes an information that librarian want to keep in their biblio
    records: any record edited in Koha loose its NSB/NSE characters.

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBUG 6098 zebra conf NSB NSE indexed as space
Fridolyn SOMERS [Wed, 6 Apr 2011 15:44:52 +0000 (17:44 +0200)]
BUG 6098 zebra conf NSB NSE indexed as space

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 5358: Show cancelled orders in basket page
Julian Maurice [Sat, 5 Nov 2011 09:35:48 +0000 (15:05 +0530)]
Bug 5358: Show cancelled orders in basket page

Signed-off-by: Christophe Croullebois <christophe.croullebois@biblibre.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoMerge remote-tracking branch 'origin/new/bug_2629'
Paul Poulain [Tue, 10 Jan 2012 22:35:48 +0000 (23:35 +0100)]
Merge remote-tracking branch 'origin/new/bug_2629'

12 years agoBug 2629 - Diacritics not being ignored when searching
Albert Oller [Wed, 30 Nov 2011 00:16:51 +0000 (19:16 -0500)]
Bug 2629 - Diacritics not being ignored when searching

/etc/zebradb/etc/word-phrase-utf.chr
added Cc miniscule and Cc circumflex; added Kk acute accent.

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
- imported marc record from the bug with the offending diacritic
- reindexed
- searched for the title - result found! Yay!

12 years agoBug 5543 - Date ISO format wrong separator
Owen Leonard [Wed, 7 Dec 2011 17:18:53 +0000 (12:18 -0500)]
Bug 5543 - Date ISO format wrong separator

This patch converts the changes in Fridolyn SOMERS patch
to T:T and adds an update to the database to correct
the description there.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 years agoBug 7278 follow-up DBrev number
Paul Poulain [Tue, 10 Jan 2012 22:00:04 +0000 (23:00 +0100)]
Bug 7278 follow-up DBrev number

12 years agoBug 7278: Follow up fixing display of item informaton on detail page
Katrin Fischer [Tue, 20 Dec 2011 07:40:03 +0000 (08:40 +0100)]
Bug 7278: Follow up fixing display of item informaton on detail page

Fixes a display problem in the item table on staff detail page.

To test:
Add a record with 3 items:
- 1 with copynumber
- 1 with materials specified
- 1 with opac notes

Before patch the table will be broken a bit and the headings
don't match the contents (wrong sequence).

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7278 : Additional Materials
Chris Cormack [Thu, 1 Dec 2011 01:19:44 +0000 (14:19 +1300)]
Bug 7278 : Additional Materials

Part 2: This patch shows the message at checkout and checkin

How to test:
* Add a note in cataloguing
* Check it displays at checkout and checkin
* Check items without a note don't display anything

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
12 years agoBug 7728 : Materials Specified field made larger and displayed
Chris Cormack [Wed, 30 Nov 2011 21:46:52 +0000 (10:46 +1300)]
Bug 7728 : Materials Specified field made larger and displayed

This first page makes the database change, and displays the field on
the detail.pl and moredetail.pl pages in the staff client

How to Test:

* Add a note to the materials specified page in cataloguing (952
subfield 3 for MARC21, but it shouldn't matter as long as you have a
field mapped to items.materials
* Check it displays at catalogue/detail.pl
* Check it displays at catalogue/moredetail.pl

Patch to follow to have the note display at checkin/checkout

http://bugs.koha-community.org/show_bug.cgi?id=7278

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Fixed conflicts in updatedatabase.pl and kohastructure.sql

12 years agoBug 7077, follow-up
Paul Poulain [Fri, 6 Jan 2012 16:45:02 +0000 (17:45 +0100)]
Bug 7077, follow-up

* DBrev number
* added a small text to the text displayed when upgrading (3.6 behaviour & before 3.6 behaviour)

12 years agoFix for Bug 7077 - Add system pref to control behavior of submitting empty barcode...
Owen Leonard [Fri, 21 Oct 2011 19:04:53 +0000 (15:04 -0400)]
Fix for Bug 7077 - Add system pref to control behavior of submitting empty barcode field

Adds a new system preference, CircAutoPrintQuickSlip:

When an empty an empty barcode field is submitted in circulation
[ clear the screen | open a print quick slip window ].

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Fixed a merge conflict with the updatedatabase.pl

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Another merge conflict resolved. Marked as Passed QA.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry
Srdjan Jankovic [Mon, 10 Oct 2011 00:12:27 +0000 (13:12 +1300)]
Bug 6190: BorrowerUnwantedField syspref and removing fields from the patron entry

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with example from bug and by deleting parts of it:
cardnumber|surname|firstname|title|othernames|initials|streetnumber|streettype|address|address2|city|state|zipcode|country|email|phone|mobile|fax|emailpro|phonepro|B_streetnumber|B_streettype|B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_email|B_phone|dateofbirth|branchcode|categorycode|dateenrolled|dateexpiry|gonenoaddress|lost|debarred|contactname|contactfirstname|contacttitle|borrowernotes|relationship|sex|password|userid|opacnote|contactnote|sort1|sort2|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone

Note: This only affects the edit screen, not the patron detail tab.
A nice enhancement would be to make this page follow the system preference too.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA comments on Bugzilla. Passing QA.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
* DBrev defined
* small improvement suggested by Marcel added = there is now a link to the schema page on the systempreference

12 years agoBug 6374: default value for Size in result pages
Adrien Saurat [Tue, 3 Jan 2012 14:28:50 +0000 (15:28 +0100)]
Bug 6374: default value for Size in result pages

When no size info is available, an empty string is
sent to the TT (if nothing is sent, the TT engine
will display another information, irrelevant for Koha).

Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
Works beautifully!

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 3651 Follow-up, Require patron login to send shelves and baskets
Owen Leonard [Thu, 29 Dec 2011 16:47:44 +0000 (11:47 -0500)]
Bug 3651 Follow-up, Require patron login to send shelves and baskets

The fix for Bug 4289, "Add a syspref 'OpacPublic', to hide OPAC
search-bar and force authentication on all OPAC pages" incorrectly
made some page permissions dependent on the value of the OpacPublic
setting. Some pages should require authentication no matter what.

This patch returns opac-sendbasket.pl to the state it was in before
Bug 4289, Bug 4274 notwithstanding. I have added the authentication
requirement to opac-sendshelf.pl to match.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
1) sending cart requires login
2) sending shelf requires login
3) updating personal details requires login

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7220 - Add IDs to check-in message dialogs to facilitate CSS customization
Chris Hall [Thu, 22 Dec 2011 02:43:08 +0000 (15:43 +1300)]
Bug 7220 - Add IDs to check-in message dialogs to facilitate CSS customization

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity
Owen Leonard [Tue, 8 Nov 2011 16:43:38 +0000 (11:43 -0500)]
Fix for Bug 7194 - OPAC detail and recent comments pages corrections for XHTML validity

- Adding html filter to subtitle output to correct unescaped ampersands
- Adding missing alt attributes to libravatar output
- Removing unecessary markup  from comments page

Bonus: Adding html_break filter to output of comments to preserve line breaks
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoFix to make date obviously editable - bug 7193
Duncan Tyler [Mon, 19 Dec 2011 00:43:21 +0000 (13:43 +1300)]
Fix to make date obviously editable - bug 7193

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch changes all date fields on subscription entry to be
obvious input fields. This makes it more obvious that you
can enter dates manually and is more consistent with how
we handle dates in other places.

Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7341 - [SIGNED-OFF] Patch to fix error produced when clicking cancel in system...
Duncan Tyler [Thu, 22 Dec 2011 01:32:22 +0000 (14:32 +1300)]
Bug 7341 - [SIGNED-OFF] Patch to fix error produced when clicking cancel in system preferences search results - bug 7341

Signed-off-by: Magnus Enger <magnus@enger.priv.no>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
12 years agoBug 7338: Follow up: show link only when there is more than 1 subscription
Katrin Fischer [Mon, 12 Dec 2011 07:39:39 +0000 (08:39 +0100)]
Bug 7338: Follow up: show link only when there is more than 1 subscription

To be tested together with
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6690

1) Create a subscription for a title
- check the link 'Show any subscription...' doesn't show now
- check the serials collection page works correctly and shows all
necessary information

2) Create a second subscription for the same title
- check a new link 'Show any subscription...' shows up now
- use links in the issue table to change between viewing the single subscription
and the overview page
- check it works correctly and all information shows up

Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
It works. With this patch, on Serials Collection page, the link, 'See any
subscription attached to this biblio' appears only when there are more than one
subscription attached to the biblio record.