]> git.koha-community.org Git - koha.git/commit
Bug 31106: Make clean_search_term escape double quotes
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 4 Jul 2022 18:19:27 +0000 (15:19 -0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 18 Jul 2022 17:37:35 +0000 (14:37 -0300)
commit24bb15785dd7f176c1ffe2bf8ae5e8a05cc0707a
tree8e9810df3e396ef2510c270ee6bcfa3d797dc214
parent73ca6e2f57d9c2271878e74e46548cb7eadea2a3
Bug 31106: Make clean_search_term escape double quotes

We noticed that several characters will break Zebra queries. So search
terms need to be quoted for things to work. In this context, double
quotes inside search terms are problematic because double quotes are
what we use for quoting strings.

This patch makes the clean_search_term method escape double quotes.

To test:
1. Apply the unit tests patch
2. Run:
   $ kshell
  k$ prove t/Koha/SearchEngine/Zebra/QueryBuilder.t
=> FAIL: It doesn't work as it should!
3. Apply this patch
4. Repeat 2
=> SUCCESS: It does the job!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/SearchEngine/Zebra/QueryBuilder.pm