]> git.koha-community.org Git - koha.git/commit
Bug 30997: Fix "CGI::param called in list context" warning in detail.pl
authorPetro Vashchuk <stalkernoid@gmail.com>
Mon, 20 Jun 2022 14:08:32 +0000 (17:08 +0300)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 15 Jul 2022 17:49:52 +0000 (11:49 -0600)
commit535f555468709316aaea99e3b71481c3b2a6a800
treec1882ae709df1a5330555a4cdbafabc91ad2c399
parent3eceb3d5fe9c8c5ae6ce04720364acd21be0a7e6
Bug 30997: Fix "CGI::param called in list context" warning in detail.pl

CGI param found1 should be explicitly scalar,
or else error log gets flooded with this warning:

CGI::param called in list context from
/usr/share/koha/intranet/cgi-bin/catalogue/detail.pl line 622

This patch fixes it by working with it in a scalar context.
The functionality still remains the same but warning doesn't flood
error log.

To reproduce:
1. Open any biblio (details.pl) page.
2. Check the error log and find the upper mentioned warning,
check the timestamp to ensure that it was added when you loaded the page.
3. Apply the patch.
4. Load the page again, ensure that the same warning doesn't get added
to the log file again.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 407564e3940ad08030383078fd1ce5c530a19f2d)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
catalogue/detail.pl