]> git.koha-community.org Git - koha.git/commit
Bug 31036: Treat SIP00 that same as CASH
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 24 Jun 2022 08:20:52 +0000 (09:20 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 18 Jul 2022 13:27:59 +0000 (10:27 -0300)
commit9d8be887d08f523171faa30b35ff86798c4b0115
treea20c464fb9cc07fbb0cf155b3491c4367e99c654
parent1672d0c1c0be45aba66c17b2024495852f1ab2fe
Bug 31036: Treat SIP00 that same as CASH

SIP00 is the code for CASH transactions that have taken place on a SIP
client.  Cash management treats CASH type transactions as a special case
for banking and register requirements. This patch brings SIP00 in line
with the CASH handling code of cash management.

Test plan
1) Enable cash management with 'EnablePointOfSale'
2) Enable cash registers with 'UseCashRegisters'
3) Add a cash register via 'Administration > Cash registers'
4) Make some payments against the ash register in the staff client
5) Attempt to make a payment via a SIP client without having associated
   a cash register to the SIP account config
5a) This should now fail
6) Attach the cash register to the SIP account used above
6a) Payment should now work again on SIP transactions
7) Look at the cash register details page for the cash register
7a) 'Bankale' should now include cash from both SIP and Staff client
sales

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Account.pm
Koha/Account/Line.pm
koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt