]> git.koha-community.org Git - koha.git/commit
Bug 31036: Treat SIP00 that same as CASH
authorMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 24 Jun 2022 08:20:52 +0000 (09:20 +0100)
committerLucas Gass <lucas@bywatersolutions.com>
Tue, 23 Aug 2022 17:20:17 +0000 (17:20 +0000)
commitc3c889e7f4b440bcbac8ac0a3eb77e5cfe4c322a
tree5e5f25652b47f542c98f68e2b2b71c18638124b3
parente9fde507b643b0f8b2605f3fea838860d1a01261
Bug 31036: Treat SIP00 that same as CASH

SIP00 is the code for CASH transactions that have taken place on a SIP
client.  Cash management treats CASH type transactions as a special case
for banking and register requirements. This patch brings SIP00 in line
with the CASH handling code of cash management.

Test plan
1) Enable cash management with 'EnablePointOfSale'
2) Enable cash registers with 'UseCashRegisters'
3) Add a cash register via 'Administration > Cash registers'
4) Make some payments against the ash register in the staff client
5) Attempt to make a payment via a SIP client without having associated
   a cash register to the SIP account config
5a) This should now fail
6) Attach the cash register to the SIP account used above
6a) Payment should now work again on SIP transactions
7) Look at the cash register details page for the cash register
7a) 'Bankale' should now include cash from both SIP and Staff client
sales

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 9d8be887d08f523171faa30b35ff86798c4b0115)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Koha/Account.pm
Koha/Account/Line.pm
koha-tmpl/intranet-tmpl/prog/en/modules/pos/register.tt
koha-tmpl/intranet-tmpl/prog/en/modules/pos/registers.tt