]> git.koha-community.org Git - koha.git/commit
Bug 29771: Scalar context for split
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 23 Dec 2021 19:58:57 +0000 (16:58 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 11 Mar 2022 11:35:50 +0000 (06:35 -0500)
commite5dc760b92bd939245c3d24a0cfa3db99f9ac764
tree22a80405b3f471d68f42a0998ca53e677de4215d
parent1cfa7e38458b0e644ba7a34ae81520987071eca1
Bug 29771: Scalar context for split

This patch tackles a very specific scenario. Calling split(...,
CGI::param) makes it be called in list context. The split docs say:

split /PATTERN/,EXPR,LIMIT

this means the first CGI param will be used as EXPR and the second one
as LIMIT, which is wrong anyway. So the fix is to just force scalar
context.

To test:
1. Not sure, just make sure nothing breaks when using the scripts in the
   browser.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
circ/article-request-slip.pl
circ/waitingreserves.pl
reserve/request.pl
tools/batch_delete_records.pl
tools/batch_record_modification.pl
tools/inventory.pl