]> git.koha-community.org Git - koha.git/commit
Bug 30072: Add missing hold actions plugin hooks
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 11 Feb 2022 18:28:31 +0000 (15:28 -0300)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 4 Mar 2022 14:26:34 +0000 (09:26 -0500)
commitf2d1b126b97ede8d67a3deee97c3a2dc44b334c8
tree1f7e40a0c82e4eb301e6c544973e115829456888
parentecbe50aa317a27d6ce55317ceec51e8b1c72c6a3
Bug 30072: Add missing hold actions plugin hooks

This patch introduces the after_hold_action plugin hook, with 4
different 'action' parameters:

- fill
- cancel
- suspend
- resume

To test:
1. Apply the unit tests
2. Run:
   $ kshell
  k$ t/db_dependent/Koha/Plugins/Holds_hooks.t -v
=> FAIL: The hooks are not in the code, so the expected output from the
Koha::Plugin::Test plugin is not there, and the tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Note: I think we could deprecate 'after_hold_create' and migrate it to
the one introduced here, using the 'place' action.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Reserves.pm
Koha/Hold.pm