From 0dbf76c290f031e58dcb04e16047f1bd984560ef Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 16 Jan 2020 14:10:18 -0500 Subject: [PATCH] Bug 24441: Error when checking in an item with BranchTansferLimitsType set to itemtype It appears that the transition to using Koha::Item in AddReturn has introduced a bug. Previously $item was a hashref with the key 'itemtype', now that it's an object, it has no itemtype method and so triggers an error with the message "The method Koha::Item->itemtype is not covered by tests!". Test Plan: 1) Enable Branch Transfer Limits via itemtype 2) Check in an item 3) Note the error 4) Apply this patch 5) Restart all the things! 6) Check in an item 7) No error! Signed-off-by: Kyle M Hall Signed-off-by: Maribeth (Turner) Shafer Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize --- C4/Circulation.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index c3629c2472..e58aa2c983 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2111,7 +2111,7 @@ sub AddReturn { # Transfer to returnbranch if Automatic transfer set or append message NeedsTransfer if (!$is_in_rotating_collection && ($doreturn or $messages->{'NotIssued'}) and !$resfound and ($branch ne $returnbranch) and not $messages->{'WrongTransfer'}){ - my $BranchTransferLimitsType = C4::Context->preference("BranchTransferLimitsType"); + my $BranchTransferLimitsType = C4::Context->preference("BranchTransferLimitsType") eq 'itemtype' ? 'effective_itemtype' : 'ccode'; if (C4::Context->preference("AutomaticItemReturn" ) or (C4::Context->preference("UseBranchTransferLimits") and ! IsBranchTransferAllowed($branch, $returnbranch, $item->$BranchTransferLimitsType ) -- 2.39.5