From 0f3fef5cae94b64f7ca636be082d4d4c02e1fae9 Mon Sep 17 00:00:00 2001 From: Zoe Bennett Date: Wed, 17 Jan 2018 04:01:01 +0000 Subject: [PATCH] Bug 19989: Use Koha::Patron::Modifications->delete instead of loop Test: 1) Make a change to the user in the OPAC 2) In the staff client make sure this is the only request Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- opac/opac-memberentry.pl | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/opac/opac-memberentry.pl b/opac/opac-memberentry.pl index 12eebbb813..c680d7d07a 100755 --- a/opac/opac-memberentry.pl +++ b/opac/opac-memberentry.pl @@ -272,13 +272,7 @@ elsif ( $action eq 'update' ) { $borrower_changes{borrowernumber} = $borrowernumber; $borrower_changes{extended_attributes} = to_json($extended_attributes_changes); - # FIXME update the following with - # Koha::Patron::Modifications->search({ borrowernumber => $borrowernumber })->delete; - # when bug 17091 will be pushed - my $patron_modifications = Koha::Patron::Modifications->search({ borrowernumber => $borrowernumber }); - while ( my $patron_modification = $patron_modifications->next ) { - $patron_modification->delete; - } + my $patron_modifications = Koha::Patron::Modifications->search({ borrowernumber => $borrowernumber })->delete; my $m = Koha::Patron::Modification->new( \%borrower_changes )->store(); -- 2.39.5