From 165e8750b8e6b57050f11884e58ce85c2888f243 Mon Sep 17 00:00:00 2001 From: Dobrica Pavlinusic Date: Fri, 8 Nov 2013 14:50:38 +0100 Subject: [PATCH] Bug 11216: fix bug where editing patron creates indefinite manual restriction Editing partron data results in unintended adding of indefinite manual restriction to it. Reason for it is hidden field add_debarment which is wrongly initialized to 1 instead of 0. Also JavaScript code seems to want to toggle checkbox, and since this field is hidden correct approach would be to change its value to 1. Test scenario: 1. edit patron data 2. verify that debarrment is wrongly added 3. remove debarrment 3. apply this patch 4. edit patron again 5. verify that debarrment wasn't added 6. intentionally add debarrment and verify that it's saved 7. add debarment, enter something in comment but press cancel and verify that debarment isn't added Signed-off-by: Chris Cormack This fixes this blocker, however, with or without the patch, the date is not saved correctly. I will file a new bug for that Signed-off-by: Jonathan Druart Signed-off-by: Galen Charlton --- .../prog/en/modules/members/memberentrygen.tt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt index b1585564ef..4aa88cf2c8 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt @@ -59,7 +59,7 @@ }); $("#cancel_manual_restriction").on("click",function(e){ $('#debarred_expiration').val(''); - $('#add_debarment').prop('checked', false); + $('#add_debarment').val(0); $('#debarred_comment').val(''); mrlink.show(); mrform.hide(); @@ -1221,11 +1221,11 @@ [% END %]

Add manual restriction

- + Add manual restriction
    -
  1. -
  2. +
  3. +
  4. Clear date
-- 2.39.5