From 208225f34c2ef26b709070fb5365d81a4389f346 Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Mon, 15 Nov 2021 18:25:20 +0000
Subject: [PATCH] Bug 29487: Set autocomplete off for userid/password fields at
 login

This patch adjust:
Intranet login
Opac-main
Opac-main - 'log in to your account modal'

To test:
Login at the three places above
Confirm html shows autocomplete off on the fields
Confirm logins work

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt        | 4 ++--
 koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 4 ++--
 koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt  | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
index 7cfe32644a..73b3761764 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/auth.tt
@@ -69,10 +69,10 @@
         <input type="hidden" name="[% INPUT.name | html %]" value="[% INPUT.value | html %]" />
     [% END %]
     <p><label for="userid">Username:</label>
-    <input type="text" name="userid" id="userid" class="input focus" value="[% userid | html %]" size="20" tabindex="1" />
+    <input type="text" name="userid" id="userid" class="input focus" value="[% userid | html %]" size="20" tabindex="1" autocomplete="off" />
     </p>
     <p><label for="password">Password:</label>
-    <input type="password" name="password" id="password" class="input" value="" size="20" tabindex="2" />
+    <input type="password" name="password" id="password" class="input" value="" size="20" tabindex="2" autocomplete="off" />
     </p>
 
     [% UNLESS IndependentBranches %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
index b87ddd2aec..c2cf93a090 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc
@@ -392,8 +392,8 @@
                         [% UNLESS Koha.Preference('opacShibOnly') %]
                             <input type="hidden" name="koha_login_context" value="opac" />
                             <fieldset class="brief">
-                                <label for="muserid">Login:</label><input type="text" id="muserid" name="userid" />
-                                <label for="mpassword">Password:</label><input type="password" id="mpassword" name="password" />
+                                <label for="muserid">Login:</label><input type="text" id="muserid" name="userid" autocomplete="off" />
+                                <label for="mpassword">Password:</label><input type="password" id="mpassword" name="password" autocomplete="off" />
                                 [% IF OpacLoginInstructions %]
                                     <div id="nologininstructions-modal" class="nologininstructions">
                                         [% PROCESS koha_news_block news => OpacLoginInstructions %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
index 937d2bdaf6..12cb72e35c 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt
@@ -190,9 +190,9 @@
                                             <p>If you do not have a Google account, but do have a local account, you can still log in: </p>
                                         [% END # /IF GoogleOpenIDConnect %]
                                         <label for="userid">Login:</label>
-                                        <input class="form-control" type="text" id="userid" name="userid" />
+                                        <input class="form-control" type="text" id="userid" name="userid" autocomplete="off" />
                                         <label for="password">Password:</label>
-                                        <input class="form-control" type="password" id="password" name="password" />
+                                        <input class="form-control" type="password" id="password" name="password" autocomplete="off" />
                                         <fieldset class="action">
                                             <input type="submit" value="Log in" class="btn btn-primary" />
                                         </fieldset>
-- 
2.39.5