From 2643f0ec39d6125543df0d6e37f716e5ed518397 Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Thu, 28 Mar 2013 15:52:13 +0100 Subject: [PATCH] Bug 9947 - Creating item for received serial prefills enumchron subfield In serial receiving : When creating an item for an issue, a javascript prefilles the $h subfield with issue number. This is for MARC21, in UNIMARC serial number is on $v. This patch replaces hard-coded value with the subfield mapped with "items.enumchron". Test plan : - Set "Koha to MARC mapping" of "items.enumchron" on a subfield other than $h, ie $z - Go to a serial subscription detail with "Serial receipt creates an item record" - Click on "Receive" - On an issue, click on "Click to add item" => Check that issue number is copied into selected subfield, ie $z You may test that with no mapping of "items.enumchron" there is no javascript error Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Nice catch! Works as advertised. All tests pass after fixing tabulation characters in serials-edit.tt. Signed-off-by: Jared Camins-Esakov --- .../prog/en/modules/serials/serials-edit.tt | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt index 6ab28c746b..5c8c80c049 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt @@ -68,13 +68,13 @@ function unHideItems(index,labelindex, serialId) { label = document.getElementById(labelindex); label.style.display='none'; - // Prefilling 995$h with serial enumeration/issue number - // Getting item id - itemid = $("fieldset#" + index + " div.cataloguing_additem_itemlist div.items").attr("id"); - // Getting subfield id - subfieldid = "subfield" + itemid.substr(4) + "h"; - // Setting text field - $("#" + subfieldid + " input[type='text']").val($("#serialseq" + serialId).val()); + // Prefilling enumcron subfield with serial enumeration/issue number + // Getting item div + item_div = $("fieldset#" + index + " div.cataloguing_additem_itemlist div.items"); + // Getting subfield with enumcron mapping + subfield_div = $(item_div).find("input[name='kohafield'][value='items.enumchron']").parent(); + // Setting text field + $(subfield_div).children("input[type='text'][name='field_value']").val($("#serialseq" + serialId).val()); } function HideItems(index,labelindex) { -- 2.39.5