From 27ead7a75732d11a3af486c19d8ae8443826c124 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 16 Sep 2021 15:28:14 +0000
Subject: [PATCH] Bug 29042: Improve formatting of entry form in Additional
 Contents

This patch makes some corrections to the Additional Contents template so
that the content entry form can be styled like other similar forms in
the staff interface.

The patch also updates the form's "title" field so that it is longer and
has a maxlength attribute matching the size of the table column.

To test, apply the patch and go to Tools -> News.

 - Create a new news item.
 - In the entry form, confirm that the "Title" and "Content" fields are
   styled consistently with other similar forms.
 - Confirm that the "title" field is longer.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../en/modules/tools/additional-contents.tt   | 35 +++++++++----------
 1 file changed, 16 insertions(+), 19 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
index 17955a08f8..2f74dfbcfc 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/additional-contents.tt
@@ -205,7 +205,7 @@
                 [% UNLESS languages.size %]
                     <li>
                         <label for="title" class="required">Title: </label>
-                        <input id="title" size="30" type="text" name="title" value="[% additional_content.title | html %]" required="required" class="required" /> <span class="required">Required</span>
+                        <input id="title" size="100" maxlength="250" type="text" name="title" value="[% additional_content.title | html %]" required="required" class="required" /> <span class="required">Required</span>
                     </li>
                 [% END %]
                 <li>
@@ -248,29 +248,26 @@
                 </ul>
 
                 [% FOR language IN languages %]
-                    <div id="lang_[% language.lang | uri %]" class="lang" data-lang="[% language.description | html %]">
-                        <div style="clear:both;">
-
-                            <fieldset>[%# FIXME We should remove list-style:none; and use class="rows" here but it does not work. Owen please help! %]
-                                <ol>
-                                    <li style="list-style: none;">
-                                        <label for="title_[% language.lang | html %]">Title: </label>
-                                        <input id="title_[% language.lang| html %]" size="30" type="text" name="title" value="[% translated_contents.item(language.lang).title | html %]"></span>
-                                    </li>
-                                    <li style="list-style: none;">
-                                        <label for="content_[% language.lang | html %]">Content: </label>
-                                        <textarea name="content" id="content_[% language.lang | html %]"  cols="75" rows="10">[% translated_contents.item(language.lang).content | html %]</textarea>
-                                        <input type="hidden" name="lang" value="[% language.lang | html %]" />
-                                    </li>
-                                </ol>
-                            </fieldset>
-                        </div>
+                    <div id="lang_[% language.lang | uri %]" class="lang clearfix" data-lang="[% language.description | html %]">
+                        <fieldset class="rows">
+                            <ol>
+                                <li style="list-style: none;">
+                                    <label for="title_[% language.lang | html %]">Title: </label>
+                                    <input id="title_[% language.lang| html %]" size="100" maxlength="250" type="text" name="title" value="[% translated_contents.item(language.lang).title | html %]">
+                                </li>
+                                <li style="list-style: none;">
+                                    <label for="content_[% language.lang | html %]">Content: </label>
+                                    <textarea name="content" id="content_[% language.lang | html %]"  cols="75" rows="10">[% translated_contents.item(language.lang).content | html %]</textarea>
+                                    <input type="hidden" name="lang" value="[% language.lang | html %]" />
+                                </li>
+                            </ol>
+                        </fieldset>
                     </div>
                 [% END %]
             </div>
         [% ELSE %]
             <div id="lang_default">
-                <div style="clear:both;">
+                <div class="clearfix">
                     <textarea name="content" id="content_default"  cols="75" rows="10">[% additional_content.content | html %]</textarea>
                 </div>
             </div>
-- 
2.39.5