From 37ec008df79d36f065b1138912cbfd2b3d37565f Mon Sep 17 00:00:00 2001 From: Jacek Ablewicz Date: Mon, 23 Jun 2014 12:08:26 +0200 Subject: [PATCH] Bug 12143 - hiding alternate address on patron self registration doesn't hide heading MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch fixes the following issue: in OPAC self registration form, even if all alternate address fields are configured as hidden, the heading for "Alternate address" still shows. To test: 1/ Confirm the issue: hide all alternate adres field names (i.e., enter B_address|B_address2|B_city|B_state|B_zipcode|B_country|B_phone| B_email|contactnote into PatronSelfRegistrationBorrowerUnwantedField system prefrence). 2/ Observe that "Alternate address" section heading still shows in patron self registration form ("your personal details" tab), despite that all section fields are configured as hidden. 3/ Apply patch. 4/ Reload OPAC self registration form; confirm that "Alternate address" is not displyed any longer, and the issue is now fixed. 5/ Remove some field name (e.g. B_address2) from PatronSelfRegistrationBorrowerUnwantedField; ensure that "Alternate address" heading does show if at least one section field is not hidden. 6/ Test steps 1-5 should be performed/repeated in both bootstrap and prog OPAC themes. Followed test plan with prog and bootstrap themes, works as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Signed-off-by: Chris Cormack --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 4417171302..7f31c967f4 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -450,7 +450,7 @@ [% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && hidden.defined('B_city') && - hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_county') && + hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_country') && hidden.defined('B_phone') && hidden.defined('B_email') && hidden.defined('contactnote') %]
diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt index 0e21010a17..1c14298d3c 100644 --- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-memberentry.tt @@ -458,7 +458,7 @@ [% UNLESS hidden.defined('B_address') && hidden.defined('B_address2') && hidden.defined('B_city') && - hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_county') && + hidden.defined('B_state') && hidden.defined('B_zipcode') && hidden.defined('B_country') && hidden.defined('B_phone') && hidden.defined('B_email') && hidden.defined('contactnote') %]
-- 2.39.5