From 568cbb3a0e698c2b263bc27ead9cacb3fcd170ea Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Fri, 13 Dec 2019 23:01:05 +0000
Subject: [PATCH] Bug 24085: Make print and cancel-hold buttons instead of
 submit

 To test:
 1 - Place a hold on an item
 2 - Check in the item to trigger the hold
 3 - Test both the print and cancel buttons to make sure all looks
     correct

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../intranet-tmpl/prog/en/modules/circ/returns.tt      | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
index d8aad43003..05c2eae869 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
@@ -474,11 +474,11 @@
                                                     </button>
 
                                                     <input type="hidden" name="print_slip" value="0" />
-                                                    <button type="submit" class="btn btn-default print">
+                                                    <button type="button" class="btn btn-default print">
                                                         <i class="fa fa-print"></i> Print slip and confirm
                                                     </button>
 
-                                                    <button type="submit" class="btn btn-default deny cancel-hold">
+                                                    <button type="button" class="btn btn-default deny cancel-hold">
                                                         <i class="fa fa-times"></i> Cancel hold
                                                     </button>
                                                 </div> <!-- /.modal-footer -->
@@ -521,7 +521,7 @@
                                                 <div class="modal-footer">
                                                     [% IF !transfer %]
                                                         <button type="submit" name="dotransfer" value="Yes" class="btn btn-default approve"><i class="fa fa-check"></i> Yes</button>
-                                                        <button type="submit" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;&amp;branchcode=[% returnbranch | uri %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
+                                                        <button type="button" name="dotransfer" value="Yes" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;&amp;branchcode=[% returnbranch | uri %]&amp;op=slip"><i class="fa fa-print"></i> Yes, print slip</button>
                                                         <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No"><i class="fa fa-times"></i> No</button>
                                                     [% ELSE %]
                                                         <button type="button" data-dismiss="modal" class="btn btn-default approve"><i class="fa fa-check"></i> OK</button>
@@ -636,14 +636,14 @@
                                                         <button type="submit" class="btn btn-default approve">
                                                             <i class="fa fa-check"></i> Confirm hold and transfer
                                                         </button>
-                                                        <button type="submit" class="btn btn-default print">
+                                                        <button type="button" class="btn btn-default print">
                                                             <i class="fa fa-print"></i> Print slip, transfer, and confirm
                                                         </button>
                                                     [% ELSE %]
                                                         <button type="submit" class="btn btn-default approve">
                                                             <i class="fa fa-check"></i> Confirm hold
                                                         </button>
-                                                        <button type="submit" class="btn btn-default print">
+                                                        <button type="button" class="btn btn-default print">
                                                             <i class="fa fa-print"></i> Print slip and confirm
                                                         </button>
                                                     [% END %]
-- 
2.39.5