From 6a1fc8d271a028286cf1bf72b228daa87b027880 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 16 May 2023 16:36:26 +0200
Subject: [PATCH] Bug 32060: Use selectrow_array

Trivial ergonomic patch, use selectrow_array, no need to prepare the
query

+ perltidy the sub

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit afe24bce2372a748c1960c8e383232f348278a0e)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
---
 C4/Biblio.pm | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/C4/Biblio.pm b/C4/Biblio.pm
index 5f2c7f518b..1c9c4209d4 100644
--- a/C4/Biblio.pm
+++ b/C4/Biblio.pm
@@ -1832,15 +1832,15 @@ sub UpsertMarcControlField {
 
 sub GetFrameworkCode {
     my ($biblionumber) = @_;
-    my $cache = Koha::Cache::Memory::Lite->get_instance();
-    my $cache_key = "FrameworkCode-$biblionumber";
-    my $frameworkcode = $cache->get_from_cache($cache_key);
-    unless (defined $frameworkcode) {
+    my $cache          = Koha::Cache::Memory::Lite->get_instance();
+    my $cache_key      = "FrameworkCode-$biblionumber";
+    my $frameworkcode  = $cache->get_from_cache($cache_key);
+    unless ( defined $frameworkcode ) {
         my $dbh = C4::Context->dbh;
-        my $sth = $dbh->prepare("SELECT frameworkcode FROM biblio WHERE biblionumber=?");
-        $sth->execute($biblionumber);
-        ($frameworkcode) = $sth->fetchrow;
-        $cache->set_in_cache($cache_key, $frameworkcode);
+        ($frameworkcode) = $dbh->selectrow_array(
+            "SELECT frameworkcode FROM biblio WHERE biblionumber=?",
+            undef, $biblionumber );
+        $cache->set_in_cache( $cache_key, $frameworkcode );
     }
     return $frameworkcode;
 }
-- 
2.39.5