From 6c48a1e2c2b5ea246a4ea0f3b0e2d8dadc3279ed Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 27 Mar 2018 15:09:08 +0000 Subject: [PATCH] Bug 18791: (follow up) Fix translation of copy messages This patch updates DataTables configuration so that more strings are translatable: https://datatables.net/extensions/buttons/examples/html5/copyi18n.html To test, apply the patch and clear your browser cache. - Open the account tab for a patron who has only one fine. - Confirm that the new DataTables buttons appear. - Click the 'Copy' button and confirm that a "Copied 1 row to clipboard" message appears. - Test again with a patron who has multiple fines, confirm that the message reads "Copied X rows to clipboard." To test the translation: - Confirm that "Copied 1 row to clipboard" is missing from the language file you're testing with (misc/translator/po/xx-YY-staff-prog.po). - Run 'translate update xx-YY' - Check that the clipboard strings are now in the po file. - Add translations for those strings. - Run 'translate update xx-YY' and 'translate install xx-YY' - Switch to the translated language and clear your browser cache. - Test the 'Copy' button again. Your translated text should appear. Signed-off-by: Claire Gravely Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/en/includes/datatables.inc | 4 ++++ koha-tmpl/intranet-tmpl/prog/js/datatables.js | 10 +++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc index 480cb0146a..b6cd884561 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/datatables.inc @@ -24,6 +24,10 @@ var MSG_DT_ZERO_RECORDS = _("No matching records found"); var MSG_DT_ALL = _("All"); var CONFIG_EXCLUDE_ARTICLES_FROM_SORT = _("a an the"); + var MSG_DT_COPY_TITLE = _("Copy to clipboard"); + var MSG_DT_COPY_KEYS = _("Press ctrl or ⌘ + C to copy the table data
to your system clipboard.

To cancel, click this message or press escape."); + var MSG_DT_COPY_SUCCESS_ONE = _("Copied one row to clipboard"); + var MSG_DT_COPY_SUCCESS_X = _("Copied %d rows to clipboard"); //]]> [% Asset.js("js/datatables.js") %] diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js index 99aec8396e..9c3caf1703 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js +++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js @@ -21,7 +21,15 @@ var dataTablesDefaults = { "sLoadingRecords" : window.MSG_DT_LOADING_RECORDS || "Loading...", "sProcessing" : window.MSG_DT_PROCESSING || "Processing...", "sSearch" : window.MSG_DT_SEARCH || "Search:", - "sZeroRecords" : window.MSG_DT_ZERO_RECORDS || "No matching records found" + "sZeroRecords" : window.MSG_DT_ZERO_RECORDS || "No matching records found", + buttons: { + "copyTitle" : window.MSG_DT_COPY_TITLE || "Copy to clipboard", + "copyKeys" : window.MSG_DT_COPY_KEYS || "Press ctrl or ⌘ + C to copy the table data
to your system clipboard.

To cancel, click this message or press escape.", + "copySuccess": { + _: window.MSG_DT_COPY_SUCCESS_X || "Copied %d rows to clipboard", + 1: window.MSG_DT_COPY_SUCCESS_ONE || "Copied one row to clipboard" + } + } }, "dom": '<"top pager"ilpfB>tr<"bottom pager"ip>', "buttons": [], -- 2.39.5