From 7742d8911b08516bc3fae9ea01aa3d5ad576b06a Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Fri, 4 Mar 2016 11:37:42 -0500
Subject: [PATCH] Bug 15980: Use Font Awesome icons in subscription frequency
 deletion confirmation dialog

If you try to delete a subscription frequency which is in use by an
existing subscription you will be shown a confirmation dialog. This
dialog should use Font Awesome icons.

Other minor changes:

- Added "action" attributes to <form>s to fix validation errors.
- Added "alert" class to confirmation dialog so that it is correctly
  styled.

To test, apply the patch and go to Serials -> Frequencies.

- Click "Delete" on a frequency which is in use by a subscription.
- Verify that the confirmation dialog is styled correctly.
- Test that the "No, do not delete" button works correctly.
- Test that the "Yes, delete" button deletes the correct frequency.

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
Works as advertised

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
---
 .../en/modules/serials/subscription-frequencies.tt     | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
index 5ffbbce36f..4ddd4d0242 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-frequencies.tt
@@ -163,7 +163,7 @@ $(document).ready(function() {
 
         <h1>Frequencies</h1>
         [% IF still_used %]
-            <div class="dialog">
+            <div class="dialog alert">
                 <p>
                     This frequency is still used by [% subscriptions.size %]
                     subscription(s). Do you still want to delete it?
@@ -177,14 +177,14 @@ $(document).ready(function() {
                     [% END %]
                 </ul>
 
-                <form action="" method="get">
+                <form action="/cgi-bin/koha/serials/subscription-frequencies.pl" method="get">
                     <input type="hidden" name="op" value="del" />
                     <input type="hidden" name="confirm" value="1" />
                     <input type="hidden" name="frequencyid" value="[% frequencyid %]" />
-                    <input type="submit" class="approve" value="Yes, delete" />
+                    <button type="submit" class="approve"><i class="fa fa-fw fa-check"></i> Yes, delete</button>
                 </form>
-                <form action="" method="get">
-                    <input type="submit" class="deny" value="No, don't delete" />
+                <form action="/cgi-bin/koha/serials/subscription-frequencies.pl" method="get">
+                    <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> No, do not delete</button>
                 </form>
             </div>
         [% END %]
-- 
2.39.5