From 7d1e2bb45c0b4bed473dba5880563d912bc66959 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 17 Mar 2022 18:17:44 +0000
Subject: [PATCH] Bug 29999: (follow-up) Show the remote image tab if selected

This follow-up corrects the markup so that if a value is entered in the
"Remote image" field, the correct tab will be selected upon page load.

The patch also corrrects the input name on the "No image" field so that
the option works correctly.

To test, apply the patch and edit an authorized value.

- Select an icon from an icon set. Save, and then re-edit.
  - The correct icon set tab should be activated.
- Select "No image," save, and re-edit.
  - The "No image" tab should be selected.
- On the "Remote image" tab, enter a remote image url, e.g.
  https://via.placeholder.com/50/FF0000/FFFFFF.png. Save and re-edit.
- The "Remote image" should be selected.

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
---
 .../prog/en/modules/admin/authorised_values.tt            | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
index 12336be243..c59f878a0e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
@@ -189,7 +189,7 @@
                                         <div id="none" role="tabpanel" class="tab-pane">
                                             <div class="authval-icons">
                                                 <label for="noimage">No image:
-                                                    <input type="radio" name="imageurl" id="noimage" value="removeImage" />
+                                                    <input type="radio" name="image" id="noimage" value="removeImage" />
                                                 </label>
                                             </div>
                                         </div> <!-- /.tab-pane -->
@@ -221,7 +221,11 @@
                                             </div> <!-- /.tab-pane -->
                                         [% END # /FOREACH imageset %]
 
-                                        <div id="remote" role="tabpanel" class="tab-pane">
+                                        [% IF av.imageurl.match('^http') %]
+                                            <div id="remote" role="tabpanel" class="tab-pane active">
+                                        [% ELSE %]
+                                            <div id="remote" role="tabpanel" class="tab-pane">
+                                        [% END %]
                                             <label for="remote_image_check"> Remote image:</label>
                                             [% IF av.imageurl.match('^http') %]
                                                 <input type="radio" id="remote_image_check" name="image" value="remoteImage" checked="checked" />
-- 
2.39.5