From a6e076a7ca90446e25939915337fa52fbcf0ce3e Mon Sep 17 00:00:00 2001 From: Lucas Gass Date: Mon, 15 May 2023 21:36:35 +0000 Subject: [PATCH] Revert "Bug 33210: Add unit test" This reverts commit e925af250ff3e84dad7a4d845b6cb4957837564b. Signed-off-by: Lucas Gass --- t/db_dependent/Reserves/GetReserveFee.t | 19 +------------------ 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/t/db_dependent/Reserves/GetReserveFee.t b/t/db_dependent/Reserves/GetReserveFee.t index a5ca92ad7f..f53f7c154f 100755 --- a/t/db_dependent/Reserves/GetReserveFee.t +++ b/t/db_dependent/Reserves/GetReserveFee.t @@ -52,13 +52,6 @@ $builder->build({ reservefee => 2, }, }); -$builder->build({ - source => 'Category', - value => { - categorycode => 'XYZ2', - reservefee => 0, - }, -}); my $patron1 = $builder->build({ source => 'Borrower', value => { @@ -74,12 +67,6 @@ my $patron2 = $builder->build({ my $patron3 = $builder->build({ source => 'Borrower', }); -my $patron4 = $builder->build({ - source => 'Borrower', - value => { - categorycode => 'XYZ2', - }, -}); # One biblio and two items my $biblio = $builder->build_sample_biblio; @@ -97,7 +84,7 @@ my $item2 = $builder->build_sample_item( ); subtest 'GetReserveFee' => sub { - plan tests => 6; + plan tests => 5; C4::Circulation::AddIssue( $patron1, $item1->barcode, '2015-12-31', 0, undef, 0, {} ); # the date does not really matter my $acc2 = acctlines( $patron2->{borrowernumber} ); @@ -121,10 +108,6 @@ subtest 'GetReserveFee' => sub { t::lib::Mocks::mock_preference('HoldFeeMode', 'any_time_is_collected'); $fee = C4::Reserves::GetReserveFee( $patron2->{borrowernumber}, $biblio->biblionumber ); is( int($fee), 2, 'HoldFeeMode=any_time_is_collected, Patron 2 should be charged' ); - - t::lib::Mocks::mock_preference('HoldFeeMode', 'any_time_is_placed'); - $fee = C4::Reserves::GetReserveFee( $patron4->{borrowernumber}, $biblio->biblionumber ); - is( $fee, 0, 'HoldFeeMode=any_time_is_placed ; fee == 0, Patron 4 should not be charged' ); }; subtest 'Integration with AddReserve' => sub { -- 2.39.2