From aed056a636dd8b5231b8484ba9a8531c5d84f740 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 17 Nov 2014 12:45:22 +0100 Subject: [PATCH] Bug 12976: Fix some comment in tests Previous comments were wrong. Actually the main part of price values is correct. Only some rounding and tax values are badly calculated. Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi --- C4/Acquisition.pm | 2 -- t/Prices.t | 8 +++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm index 2fef6434eb..89691e8160 100644 --- a/C4/Acquisition.pm +++ b/C4/Acquisition.pm @@ -2871,8 +2871,6 @@ sub populate_order_with_prices { } if ($receiving) { - # The following is completely wrong. Will be fixed later. - # See the unit tests to know what is wrong. if ( $bookseller->{listincgst} ) { $order->{unitpricegsti} = Koha::Number::Price->new( $order->{unitprice} )->round; $order->{unitpricegste} = Koha::Number::Price->new( diff --git a/t/Prices.t b/t/Prices.t index 8901cad2be..7ba1cc15fe 100644 --- a/t/Prices.t +++ b/t/Prices.t @@ -120,9 +120,8 @@ for my $currency_format ( qw( US FR ) ) { receiving => 1, } ); - # Note that this configuration is *not* correct! - # unitpricegsti should be 75.28 - # totalgst should be 150.56 + + # Note that this configuration is correct \o/ compare( { got => $order_0_0->{unitpricegsti}, @@ -343,6 +342,7 @@ for my $currency_format ( qw( US FR ) ) { # Note that this configuration is *not* correct! # rrp gsti should be 82 (what we inserted!) + # => Actually we need to fix the inserted value (here we have 82.01 in DB) # gstvalue should be 7.03 instead of 7.02 compare( @@ -410,8 +410,6 @@ for my $currency_format ( qw( US FR ) ) { } ); # Note that this configuration is *not* correct! - # unitpricegsti should be 71.69 - # totalgsti should be 143.38 # gstvalue should be 7.03 compare( { -- 2.39.5