From afc55cb68cecac05dfe7a327a3c5967155e6526f Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Mon, 16 Oct 2023 21:03:55 +0200
Subject: [PATCH] Bug 33568: Hide holdings tabs if empty (SeparateHoldings)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

See comment 34.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../prog/en/modules/catalogue/detail.tt       | 24 ++++++++++++-------
 1 file changed, 16 insertions(+), 8 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
index 8055d18ca7..5d0db32902 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
@@ -273,13 +273,17 @@
 
 <ul class="nav nav-tabs" role="tablist">
     [% IF Koha.Preference('SeparateHoldings') %]
-        <li role="presentation">
-            [%# FIXME We could build the numbers from DataTable's info %]
-            <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">[% Branches.GetLoggedInBranchname | html %] holdings ([% items_to_display_count - ( other_holdings_count || 0 ) - ( hidden_count || 0 ) || 0 | html %])</a>
-        </li>
-        <li role="presentation">
-            <a href="#otherholdings"  aria-controls="otherholdings" role="tab" data-toggle="tab">Other holdings ([% other_holdings_count || 0 | html %])</a>
-        </li>
+        [% IF items_to_display_count - ( other_holdings_count || 0 ) %]
+            <li role="presentation">
+                [%# FIXME We could build the numbers from DataTable's info %]
+                <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">[% Branches.GetLoggedInBranchname | html %] holdings ([% items_to_display_count - ( other_holdings_count || 0 ) - ( hidden_count || 0 ) || 0 | html %])</a>
+            </li>
+        [% END %]
+        [% IF other_holdings_count %]
+            <li role="presentation">
+                <a href="#otherholdings"  aria-controls="otherholdings" role="tab" data-toggle="tab">Other holdings ([% other_holdings_count || 0 | html %])</a>
+            </li>
+        [% END %]
     [% ELSE %]
         <li role="presentation">
             <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">Holdings ([% items_to_display_count || 0 | html %])</a>
@@ -1285,7 +1289,11 @@
                     $(".nav-tabs a[href='#holdings']").tab("show");
                 [% END %]
             [% ELSE %]
-                $(".nav-tabs a[href='#holdings']").tab("show");
+                [% IF items_to_display_count - ( other_holdings_count || 0 ) %]
+                    $(".nav-tabs a[href='#holdings']").tab("show");
+                [% ELSE %]
+                    $(".nav-tabs a[href='#otherholdings']").tab("show");
+                [% END %]
             [% END %]
             $('#search-form').focus();
             $('.thumbnails > li > .remove').click(function() {
-- 
2.39.5