From b6b5f2b59a011ab3c234cb38b3b4d413042604ea Mon Sep 17 00:00:00 2001
From: Jared Camins-Esakov <jcamins@cpbibliography.com>
Date: Thu, 21 Mar 2013 21:06:30 -0400
Subject: [PATCH] Revert "Merge branch 'bug_8089' into 3.12-master"

This reverts commit af89f98a7a82e098a5248c4f2d3c9ff3cd5de201, reversing
changes made to cc49dc70fbadb776360b1679616f81388ca71252.

The changes made by bug 8089 caused problems with the
t/db_dependent/Context.t unit test. Given the proximity of feature
freeze and release I am exercising my RM privilege and reverting rather
than seeking to fix the problems right this moment.
---
 C4/Context.pm | 66 ++++++++++++++-------------------------------------
 1 file changed, 18 insertions(+), 48 deletions(-)

diff --git a/C4/Context.pm b/C4/Context.pm
index c666cd83f9..7709f7effb 100644
--- a/C4/Context.pm
+++ b/C4/Context.pm
@@ -19,8 +19,6 @@ package C4::Context;
 use strict;
 use warnings;
 use vars qw($VERSION $AUTOLOAD $context @context_stack $servers $memcached $ismemcached);
-use Koha::Cache;
-use Carp;
 
 BEGIN {
 	if ($ENV{'HTTP_USER_AGENT'})	{
@@ -537,55 +535,28 @@ with this method.
 # FIXME: running this under mod_perl will require a means of
 # flushing the caching mechanism.
 
-my $sysprefs;
+my %sysprefs;
 my $use_syspref_cache = 1;
-my $cache;
 
 sub preference {
     my $self = shift;
     my $var  = lc(shift);                          # The system preference to return
 
-    unless (defined $sysprefs) {
-        unless ($cache) {
-            $cache = Koha::Cache->new();
-        }
-        $sysprefs = $cache->create_hash(
-            {
-                'key'         => 'syspref',
-                'allowupdate' => 1,
-                'cache_type' => $use_syspref_cache ? '' : 'null',
-                'preload'     => sub {
-                    my $dbh      = C4::Context->dbh or return {};
-                    my $vars = $dbh->selectall_arrayref("SELECT variable, value FROM systempreferences");
-                    my %sysprefs = ();
-                    foreach my $row (@$vars) {
-                        $sysprefs{$row->[0]} = $row->[1];
-                    }
-                    return \%sysprefs;
-                },
-                'constructor' => sub {
-
-                    # Look up systempreferences.variable==$var
-                    my $var      = pop;
-                    my $sysprefs = pop || {};
-                    my $dbh      = C4::Context->dbh or return 0;
-                    my $sql =
-"SELECT value FROM systempreferences WHERE variable=? LIMIT 1";
-                    $ENV{DEBUG} && carp "Retrieving syspref $var from database";
-                    my $sth = $dbh->prepare_cached($sql);
-                    $sth->execute($var);
-                    my $res = $sth->fetchrow_hashref;
-                    if ($res && $res->{'value'}) {
-                        $sysprefs->{$var} = $res->{'value'};
-                    } else {
-                        $sysprefs->{$var} = '';
-                    }
-                    return $sysprefs;
-                },
-            }
-        );
+    if ($use_syspref_cache && exists $sysprefs{$var}) {
+        return $sysprefs{$var};
     }
-    return $sysprefs->{$var};
+
+    my $dbh  = C4::Context->dbh or return 0;
+
+    # Look up systempreferences.variable==$var
+    my $sql = <<'END_SQL';
+        SELECT    value
+        FROM    systempreferences
+        WHERE    variable=?
+        LIMIT    1
+END_SQL
+    $sysprefs{$var} = $dbh->selectrow_array( $sql, {}, $var );
+    return $sysprefs{$var};
 }
 
 sub boolean_preference {
@@ -621,7 +592,7 @@ used with Plack and other persistent environments.
 sub disable_syspref_cache {
     my ($self) = @_;
     $use_syspref_cache = 0;
-    $self->clear_syspref_cache() if defined($sysprefs);
+    $self->clear_syspref_cache();
 }
 
 =head2 clear_syspref_cache
@@ -635,8 +606,7 @@ will not be seen by this process.
 =cut
 
 sub clear_syspref_cache {
-    %{$sysprefs} = ();
-    return;
+    %sysprefs = ();
 }
 
 =head2 set_preference
@@ -667,7 +637,7 @@ sub set_preference {
     " );
 
     if($sth->execute( $var, $value )) {
-        $sysprefs->{$var} = $value;
+        $sysprefs{$var} = $value;
     }
     $sth->finish;
 }
-- 
2.39.5